Extract OSGI configuration to new package ui.config #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzymonSzafraniec
force-pushed
the
feature/extract-config-package
branch
from
2c7dbc4 to
e37ac71
Compare
|
@kwin any problems with this? |
davidjgonzalez
added
the
Skip-Changelog
kwin
requested changes
Oct 1, 2024
kwin
reviewed
Oct 1, 2024
davidjgonzalez
merged commit 3f222f7
into
Adobe-Consulting-Services:master
17 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue: #3433
Currently acs-aem-commons-all package mixes subpackages with configuration files. This change bundles the configurations in a separate package which is also included in the all package.
Another benefit is that it allows other projects to include individual ACS Commons packages while not missing the OSGI configurations (e.g. include the acs-aem-commons-bundle and acs-aem-commons-ui.config only).
Also, by including individual packages separately it's possible to control the packages installation order. This is currently impossible since including the acs-aem-commons-all is the only way to install OSGI Configurations.