Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RequestResponseFactory by Sling Request builders #3406

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Replace RequestResponseFactory by Sling Request builders #3406

merged 6 commits into from
Oct 1, 2024

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Aug 6, 2024

This closes #3404

@kwin kwin force-pushed the feature/remove-contentsync.handler-dependency branch from 8d81b86 to b51e854 Compare August 6, 2024 16:18
@kwin
Copy link
Contributor Author

kwin commented Aug 6, 2024 •
edited
Loading

This fails because AEM 6.5.21 (and uber-jar 6.5.21) exports com.day.cq.wcm.api in version 1.31.0 (from bundle com.day.cq.wcm.cq-wcm-api 5.14.18) while AEM SDK API (in newest version 2024.7.17258.20240726T172406Z-240700) exports that package only in version 1.30.0. (despite the fact that this comes with bundle com.day.cq.wcm.cq-wcm-api 5.15.28)

@cziegeler Any idea when AEMaaCS is updated to a WCM API bundle which satisfies the import-package version ranges for com.day.cq.wcm.api being generated with uber-jar 6.5.21?

@kwin kwin mentioned this pull request Aug 6, 2024
Open
3 tasks
@cziegeler
Copy link
Contributor

Thanks for reporting, we will investigate.
As a workaround I guess we could explicitly specify a version range for that package that satisfies both?

@kwin
Replace RequestResponseFactory by Sling Request builders
686e8e4 
Manually tweak import-package version ranges for
com.day.cq.wcm.cq-wcm-api due to newer version in 6.5.21 than in AEMaaCS
2024.7.17258

This closes #3404
@kwin kwin force-pushed the feature/remove-contentsync.handler-dependency branch from b51e854 to 686e8e4 Compare August 7, 2024 10:53
@kwin kwin requested a review from davidjgonzalez August 7, 2024 11:08
@davidjgonzalez davidjgonzalez added this to the 6.6.4 milestone Aug 14, 2024
@davidjgonzalez
Copy link
Contributor

Will this up the required AEM 6.5 version that contains this release? (ie. back breaking change)

@kwin
Copy link
Contributor Author

kwin commented Aug 14, 2024

Will this up the required AEM 6.5 version that contains this release? (ie. back breaking change)

Yes, requires AEM 6.5.21 (no update for AEM SDK required though)

@davidjgonzalez davidjgonzalez modified the milestones: 6.6.4, 7.0.0 Aug 14, 2024
@kwin kwin mentioned this pull request Sep 8, 2024
Merged
@davidjgonzalez davidjgonzalez modified the milestones: 7.0.0, 6.7.0 Oct 1, 2024
kwin
kwin commented Oct 1, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@davidjgonzalez davidjgonzalez merged commit d9229bb into master Oct 1, 2024
19 checks passed
@davidjgonzalez davidjgonzalez deleted the feature/remove-contentsync.handler-dependency branch October 1, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjgonzalez davidjgonzalez davidjgonzalez approved these changes

Assignees
No one assigned
Labels
technical enhancement
Projects
None yet
Milestone
6.7.0
3 participants
@kwin @cziegeler @davidjgonzalez