Use JcrPackageDefinition for retrieving metadata #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is less error prone and faster than acting on the compressed underlying ZIP binary Always close JcrPackageManager (although it should now no longer be necessary) Some refactoring This closes #3225
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3227 +/- ##
========================================
Coverage 1.34% 1.34%
Complexity 44 44
========================================
Files 721 721
Lines 29537 29515 -22
Branches 3844 3837 -7
========================================
Hits 397 397
+ Misses 29124 29102 -22
Partials 16 16 ☔ View full report in Codecov by Sentry. |
joerghoh
reviewed
Dec 5, 2023
| && otherPackageId.get().getName().equals(thisPackageId.get().getName()); | ||
| private boolean isLatestInstalled(JcrPackageDefinition referencePkgDefinition, Stream<JcrPackage> installedPackages) throws RepositoryException { | ||
| try { | ||
| Optional<@Nullable JcrPackageDefinition> lastInstalledPckDefinitionOptional = installedPackages |
There was a problem hiding this comment.
that @Nullable annotation seems a bit odd to me. Isn't Optional<> just covering the nullable case?
There was a problem hiding this comment.
Right, that was a leftover from the refactoring. Fixed now.
joerghoh
reviewed
Dec 5, 2023
| try { | ||
| return p.getDefinition(); | ||
| } catch (RepositoryException e) { | ||
| throw new UncheckedRepositoryException(e); |
There was a problem hiding this comment.
Does this exception contain enough metadata to identify the package where the exception happened? Or should we add an additional message to it?
There was a problem hiding this comment.
I now enrich the relevant exception with the package path
davidjgonzalez
approved these changes
Jan 16, 2024
davidjgonzalez
deleted the
bugfix/pck-garbage-collector-use-definitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is less error prone and faster than acting on the compressed underlying ZIP binary
Always close JcrPackageManager (although it should now no longer be necessary)
Some refactoring
This closes #3225