Do not try to set a default for Collection fields in Sling Models #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgonzalez
approved these changes
Nov 15, 2023
kwin
force-pushed
the
bugfix/fix-default-for-dispatcherflushmodelimpl
branch
from
023232e to
86ee1b8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3210 +/- ##
=========================================
Coverage ? 55.23%
Complexity ? 5469
=========================================
Files ? 720
Lines ? 29497
Branches ? 3837
=========================================
Hits ? 16293
Misses ? 11681
Partials ? 1523 ☔ View full report in Codecov by Sentry. |
kwin
force-pushed
the
bugfix/fix-default-for-dispatcherflushmodelimpl
branch
from
c17bd0f to
304e0ab
Compare
This prevents the error "WARN org.apache.sling.models.impl.ModelAdapterFactory - Cannot provide default for java.util.List<java.lang.String>" being issued due to https://issues.apache.org/jira/browse/SLING-11812 This closes #3209
kwin
force-pushed
the
bugfix/fix-default-for-dispatcherflushmodelimpl
branch
from
304e0ab to
7063967
Compare
davidjgonzalez
deleted the
bugfix/fix-default-for-dispatcherflushmodelimpl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the error "WARN
org.apache.sling.models.impl.ModelAdapterFactory - Cannot provide default for java.util.List<java.lang.String>" being issued due to https://issues.apache.org/jira/browse/SLING-11812
This closes #3209