Feature/run prs with readwrite token #2676
Conversation
|
@davidjgonzalez Why did you have to revert #2654 in the first place? (14fac98). What is different in this PR? |
|
Nothing is different - i merged #2654 to master, then updated my branch (thinking it would fix my build issue) - but it just stalled my branch's build out, so i reverted it from master since it didnt seem to be working. |
|
@davidjgonzalez Where is the build status of your fork's branch build? If it doesn't cause regressions I would like to keep it a while in master to check why forked PRs are still not working.... Also forked repo PRs are not an issue AFAIK for people having write access to ACS AEM Commons (https://github.com/orgs/Adobe-Consulting-Services/people) but only for people outside the committers group! |
|
This was the PR .. We can merge it in again to master if we want; I just don't know that PR's based on it will ever finish collecting status. I wanted to try to cut 5.0.8 tonight (and merge/re-run build across the open PR's takes so long - wanted to get a jump on it while i was working -- since updating w/ latest while time-consuming, is usually mindless :) WDYT? Merge to master for now - and admin merge PR's if we need? |
|
The issue |
|
@kwin ah - i thought they might be related due to: ScaCap/action-surefire-report#31 Either way - this issue's change seems to cause any build that included it to get stuck with:
I assume this is not expected behavior? |
|
The current yaml has one issue: GH reports (https://github.com/Adobe-Consulting-Services/acs-aem-commons/actions/runs/1167170469) |
|
ah - ok - that explains the stuck build status ( ah - in Actions tab .. of course) |
kwin
force-pushed
the
feature/run-prs-with-readwrite-token
branch
2 times, most recently
from
4cbf4ea to
47946c3
Compare
debug event with toJSON function fix yaml use caching integrated in setup-java
kwin
force-pushed
the
feature/run-prs-with-readwrite-token
branch
from
47946c3 to
bb7b2ef
Compare
No description provided.