Skip to content

Commit

Permalink
Remove JaCoCo offline instrumentation
Browse files Browse the repository at this point in the history
It incorrectly affects manifest calculation which leads to follow-up
issues with aemanalyser-m-p and is generally not recommended
(https://www.eclemma.org/jacoco/trunk/doc/instrument-mojo.html)

It was originally introduced for compatibility with PowerMock but that
is no longer used.

This closes #3494
  • Loading branch information
kwin committed Dec 16, 2024
1 parent 7601ca4 commit 80590ab
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 16 deletions.
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,18 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)

## Unreleased ([details][unreleased changes details])

## Changed

- #3494 - Remove offline instrumentation with Jacoco

## 6.9.10 - 2024-12-13

### Added
- #3484 - Redirect Manager: A servlet to export redirects to a TXT file to use with pipeline-free redirects
- #3480 - AEM Sites Copy Publish URLs

### Fixed
- #3479 - Fixed Configurations Model for Redirect Manager after change in "redirect" resource as "sling:Folder"

### Fixed

- #3483 - Fixed issue with genericlist/body.jsp importing a class from an impl package.

## 6.9.6 - 2024-11-20
Expand Down
14 changes: 1 addition & 13 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
<!-- the minimum AEMaaCS version being supported -->
<aem.sdk.api.version>2024.8.17569.20240822T203847Z-240700</aem.sdk.api.version>

<jacoco.version>0.8.11</jacoco.version>
<jacoco.version>0.8.12</jacoco.version>
<junit.jupiter.version>5.10.2</junit.jupiter.version> <!-- >= 5.x requires Java 11 -->
<!-- affects both m-compiler-p and m-javadoc-p-->
<maven.compiler.release>8</maven.compiler.release>
Expand Down Expand Up @@ -811,18 +811,6 @@ Bundle-DocURL: https://adobe-consulting-services.github.io/acs-aem-commons/
</excludes>
</configuration>
</execution>
<execution>
<id>jacoco-instrument</id>
<goals>
<goal>instrument</goal>
</goals>
</execution>
<execution>
<id>jacoco-restore-instrumented-classes</id>
<goals>
<goal>restore-instrumented-classes</goal>
</goals>
</execution>
<execution>
<id>report</id>
<phase>prepare-package</phase>
Expand Down

0 comments on commit 80590ab

Please sign in to comment.