refactor: refactor client details screen to compose with multi module

Aditya-gupta99 · Apr 6, 2024 · 78aff43 · 78aff43
1 parent 72f40fd
commit 78aff43
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosScaffold.kt b/core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosScaffold.kt
@@ -29,9 +29,10 @@ import com.mifos.core.designsystem.theme.White
 @Composable
 fun MifosScaffold(
     icon: ImageVector?,
+    title : String?,
     onBackPressed: () -> Unit,
     actions: @Composable () -> Unit,
-    snackbarHostState: SnackbarHostState,
+    snackbarHostState: SnackbarHostState?,
     bottomBar: @Composable () -> Unit,
     content: @Composable (PaddingValues) -> Unit
 ) {
@@ -54,22 +55,24 @@ fun MifosScaffold(
                     }
                 },
                 title = {
-                    Text(
-                        text = stringResource(id = R.string.feature_client),
-                        style = TextStyle(
-                            fontSize = 24.sp,
-                            fontWeight = FontWeight.Medium,
-                            fontStyle = FontStyle.Normal,
-                            fontFamily = FontFamily(Font(R.font.outfit_medium))
-                        ),
-                        color = Black,
-                        textAlign = TextAlign.Start
-                    )
+                    title?.let {
+                        Text(
+                            text = it,
+                            style = TextStyle(
+                                fontSize = 24.sp,
+                                fontWeight = FontWeight.Medium,
+                                fontStyle = FontStyle.Normal,
+                                fontFamily = FontFamily(Font(R.font.outfit_medium))
+                            ),
+                            color = Black,
+                            textAlign = TextAlign.Start
+                        )
+                    }
                 },
                 actions = { actions() }
             )
         },
-        snackbarHost = { SnackbarHost(snackbarHostState) },
+        snackbarHost = { snackbarHostState?.let { SnackbarHost(it) } },
         containerColor = White,
         bottomBar = bottomBar
     ) { padding ->

diff --git a/core/designsystem/src/main/res/values/strings.xml b/core/designsystem/src/main/res/values/strings.xml
diff --git a/.../src/main/java/com/mifos/feature/client/clientDetails/presentation/ClientDetailsScreen.kt b/.../src/main/java/com/mifos/feature/client/clientDetails/presentation/ClientDetailsScreen.kt
@@ -225,6 +225,7 @@ fun ClientDetailsScreen(
 
     MifosScaffold(
         icon = Icons.Rounded.ArrowBackIosNew,
+        title = stringResource(id = R.string.feature_client),
         onBackPressed = { onBackPressed() },
         actions = {
             IconButton(onClick = { showMenu = showMenu.not() }) {