Merge pull request bsm#67 from EastResident/feature/vcm

Add "vcm" attribute to banner object
Adikteev · Oct 28, 2019 · f0c31f9 · f0c31f9
2 parents b972a5c + 75ebdae
commit f0c31f9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/banner.go b/banner.go
@@ -24,5 +24,6 @@ type Banner struct {
 	TopFrame int             `json:"topframe,omitempty"` // Default: 0 ("1": Delivered in top frame, "0": Elsewhere)
 	ExpDir   []int           `json:"expdir,omitempty"`   // Specify properties for an expandable ad
 	Api      []int           `json:"api,omitempty"`      // List of supported API frameworks
+	Vcm      int             `json:"vcm,omitempty"`      // Represents the relationship with video. 0 = concurrent, 1 = end-card
 	Ext      json.RawMessage `json:"ext,omitempty"`
 }
diff --git a/banner_test.go b/banner_test.go
@@ -21,6 +21,7 @@ var _ = Describe("Banner", func() {
 			BType: []int{BannerTypeFrame},
 			BAttr: []int{CreativeAttributeWindowsDialogOrAlert},
 			Api:   []int{APIFrameworkMRAID1},
+			Vcm:   1,
 		}))
 	})
 

diff --git a/testdata/banner.json b/testdata/banner.json
@@ -10,5 +10,6 @@
   ],
   "api": [
     3
-  ]
+  ],
+  "vcm": 1
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ var _ = Describe("Banner", func() { @@
     			BType: []int{BannerTypeFrame},
     			BAttr: []int{CreativeAttributeWindowsDialogOrAlert},
     			Api:   []int{APIFrameworkMRAID1},
+    			Vcm:   1,
     		}))
     	})
@@ Expand Down @@