Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Kessel e2e setup #5

Closed
wants to merge 4 commits into from
Closed

[WIP] Kessel e2e setup #5

wants to merge 4 commits into from

Conversation

Adam0Brien
Copy link
Owner

@Adam0Brien Adam0Brien commented Nov 22, 2024

PR Template:

Describe your changes

  • E2E test deploy
    • Folder structure for kind setup can be found under deploy/kind
  • Test suite has been expanded in inventory_http_tests.go
  • Changes have been made to kafkaconsumer_test.go because of errors found during testing (unknown topic or partition error)
  • GH workflow for e2e tests has been changed to check the status of tests and return logs

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Copy link

github-actions bot commented Nov 22, 2024

The latest Buf updates on your PR. Results from workflow buf-pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedNov 26, 2024, 5:55 PM

@Adam0Brien Adam0Brien force-pushed the kessel-e2e-setup branch 5 times, most recently from 6b30c62 to a34b045 Compare November 26, 2024 12:28
@Adam0Brien Adam0Brien force-pushed the kessel-e2e-setup branch 3 times, most recently from a21951c to 4a90b03 Compare November 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant