Bianca Fernandez <Pipes> Hotel #34

biciclista22 · 2017-09-11T14:28:28Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	Honestly, just deciding how to divide up the different functionality, what classes would potentially be needed and imagining how they would interact with one another was challenging. I needed to decide if I would create a date range class that would be called in the Reservation class. I was toying with the idea of scrapping it, just allowing it to exist in the reservation class upon initialization, but I also weighed out how important isolated and not super dependent methods and classes are in code's design and ability to change and scale. I also recognize that many parts of my code could have used that decision making as well, breaking up complex chunks of code into simpler snippets.
Describe a concept that you gained more clarity on as you worked on this assignment.	Calling a method or an instance method in another class. I also learned more about parent and child class with the Reservation class that I used to make the Block class.
Describe a nominal test that you wrote for this assignment.	A go-to nominal test is usually to assert that a certain data structure is what it is meant to be and contains the correct number of items that I expect to be passed into it.
Describe an edge case test that you wrote for this assignment.	An edge case certainly came up with the reservation availability method where I needed to make sure that dates did not overlap. I made sure to make a smaller hotel with fewer rooms to choose from and from there, book a couple of those rooms, with some overlapping dates, creating asserts where I knew it should pass and where they should fail. It definitely was helpful in the debugging portion of that logic.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I was able to do it a little, but definitely not as much as I would like or should. I think, personally, some of it has to do with nerves and wanting to see some code on the screen. I learned my lesson though, because, with wave 3, I went right in, hacking away at what I thought could work. I quickly learned a lot of what I wrote would not work because it didn't pass the tests and would need to be rewritten and reorganized. I am thoroughly enjoying the tests as a way to gauge accuracy and even design at times.

…ted a check to make sure check in date came before check out

…m other class

…ng out hotel class methods and variables

… time trying to call the right methods

…eraction with hotel class

…each block of rooms

droberts-sea · 2017-09-11T21:44:53Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	yes - good work
Answer comprehension questions	yes - I'm glad you're enjoying testing!
Design
Each class is responsible for a single piece of the program	some - You have a `DateRange` class, but it doesn't have any instance methods, and all the information you store there is repeated elsewhere. This indicates that you've identified "keeping track of a range of dates" as a responsibility, but haven't isolated that responsibility from your other classes. I've identified a few places below where your logic could be attached to `DateRange`. In general, unless you're going to use it to isolate pieces of logic, it doesn't make sense to go through the effort of defining a whole separate class.
Classes are loosely coupled	mostly - Aside from pulling the check_in / check_out dates from the reservation and examining them manually, the classes don't know much about each other.
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	yes
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	yes
Wave 3
Create a block of rooms	yes
Check if a block has rooms	yes
Reserve a room from a block	yes
Test coverage	some missing, particularly in `Hotel`
Additional Feedback

This looks good overall! I've definitely got some opinions about your DateRange class, and I've identified a number of places where your could could be cleaned up or made DRYer. But, in general this is a pretty well-built solution to a non-trivial problem, and you've managed to keep it organized and readable too. Keep up the good work!

Make sure you check out our reference implementation, particularly the way we've structured and used DateRange, and the way we've handled testing.

droberts-sea · 2017-09-11T20:47:41Z

lib/hotel.rb

+      @rooms = []
+      room_num = 0
+      num_of_rooms.times do |room|
+        room_num += 1


Why not something like

@rooms = (1..num_of_rooms).to_a

droberts-sea · 2017-09-11T20:50:25Z

lib/hotel.rb

+    # ability to reserve a room within a block of rooms
+    #needs to match the date range of the block
+    def reserve_room_in_block(check_in, check_out, num_of_rooms)
+


I'm not sure I'm convinced by this method signature. What if two blocks have the same checkin/checkout dates and the same number of rooms? Instead, you should pass in either some sort of ID for the block, or the BlockRoom instance itself.

droberts-sea · 2017-09-11T20:50:57Z

lib/hotel.rb

+    def make_reservation(check_in, check_out, room_num)
+      if room_availability(check_in, check_out).include?(room_num)
+        @reservation_made = Reservation.new(check_in, check_out, room_num)
+        @reservation_collection << @reservation_made


This method looks good! Very clear what's going on.

droberts-sea · 2017-09-11T20:52:35Z

lib/hotel.rb

+        # binding.pry
+        if entry.check_in <= date && entry.check_out >= date
+          date_list << [entry.room_num, entry.check_in.to_s, entry.check_out.to_s]
+        end


This check, that the date falls within the reservation, would be a great candidate for an instance method on DateRange. Then you could say something like if entry.date_range.contains?(date).

droberts-sea · 2017-09-11T20:57:59Z

lib/reservation.rb

+
+      @date_range = DateRange.new(check_in, check_out)
+      @check_in = @date_range.check_in
+      @check_out = @date_range.check_out


If you're encapsulating the checkin and checkout dates in a DateRange, the you should not also store them as individual instance variables. If someone wants access to a reservation's dates, they'll have to go through the date range.

droberts-sea · 2017-09-11T21:25:53Z

specs/date_range_spec.rb

+
+  it "Checks for invalid date entry - if check in is after check out date" do
+    check_in_1 = "Sept 9 2017"
+    check_out_1 = "Sept 8 2017"


You might include an explicit check here for when the dates are the same. Whether or not it's a legal range, I feel like it's an interesting case.

droberts-sea · 2017-09-11T21:29:18Z

specs/hotel_spec.rb

+    it "can call on collection of reservations array - will be empty" do
+      Hotel::Hotel.new(20, 200).reservation_collection.must_be_instance_of Array
+      Hotel::Hotel.new(20, 200).block_reservation_collection.must_be_instance_of Array
+


Two observations about this test:

You probably don't want to instantiate two different hotels

You don't actually check that the array is empty

You might rewrite it as follows:

it "can call on collection of reservations array - will be empty" do hotel = Hotel::Hotel.new(20, 200) hotel.reservation_collection.must_be_instance_of Array hotel.reservation_collection.length.must_equal 0 hotel.block_reservation_collection.must_be_instance_of Array hotel.block_reservation_collection.length.must_equal 0 end

droberts-sea · 2017-09-11T21:30:36Z

specs/hotel_spec.rb

+
+    it "Can return an argument error if room is not available for that date range" do
+      proc { @bb_hotel.make_reservation('sept 8 2017', 'sept 9 2017', 4)}.must_raise ArgumentError
+    end  ####NOTE##### Not sure how to create a test to check if there is no problem with the code


Checking for an exception is a good call here. If you're trying to avoid it passing when you've written a bug, a common technique is to define your own exception and look for that instead.

droberts-sea · 2017-09-11T21:34:32Z

lib/hotel.rb

+    def room_availability(check_in, check_out)
+      #can be string with dates
+      rooms_available = @rooms.clone
+


I like that you've made getting a list of available rooms its own method - this both DRYs up your code and makes testing easier.

droberts-sea · 2017-09-11T21:36:23Z

specs/hotel_spec.rb

+    it "Returns the room numbers available for a certain date range" do
+      @hotel.room_availability('sept 1 2017', 'sept 3 2017').must_equal [1 ,4]
+      @hotel.room_availability('sept 5 2017', 'sept 6 2017').must_equal [2,3,4]
+      @hotel.room_availability('sept 7 2017', 'sept 8 2017').must_equal [1,3,4]


It might be nice to break this up into multiple different it blocks, to make it more obvious why each date range is interesting.

biciclista22 added 18 commits September 5, 2017 15:27

Set up files - rake, spec_helper, date range, room, and reservation

c4c35ba

Initialize method on DateRange with passing tests

05cdb21

Changed Date.new to date parse to be able to take in strings and crea…

a0addab

…ted a check to make sure check in date came before check out

create total cost method - learned how to call an instance method fro…

50b6952

…m other class

add tests to understand what is in the reservation array, beginfleshi…

94a24d7

…ng out hotel class methods and variables

Add #make_reservation Hotel class method with passing tests - lots of…

e489640

… time trying to call the right methods

wave 1 complete with passing tests

ab0ddc7

remove instance variable of date list in hotel class to local variable

3e183d5

create #room availability given a date range

45e0568

add sort and uniq method call to room availaibility array

9bbc3fa

availability functionality with passing tests - draft 2

9e33f2b

wave 2 complete with passing tests - may need more scrutinizing tests

f558bd9

add block and block spec and initial framework of block class and int…

23c7790

…eraction with hotel class

Create two arrays - booked and available within Blockroom

fff14fd

Passing make block reservation method

c3f3211

Can book rooms in a given block

a49f9f7

Can check if block has any available rooms

3489cb0

Correction to availability logic to go into actual room array within …

729c650

…each block of rooms

droberts-sea reviewed Sep 11, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bianca Fernandez <Pipes> Hotel #34

Bianca Fernandez <Pipes> Hotel #34

biciclista22 commented Sep 11, 2017

droberts-sea commented Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

droberts-sea Sep 11, 2017

Bianca Fernandez <Pipes> Hotel #34

Are you sure you want to change the base?

Bianca Fernandez <Pipes> Hotel #34

Conversation

biciclista22 commented Sep 11, 2017

Hotel

Comprehension Questions

droberts-sea commented Sep 11, 2017

Hotel

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment