Pipes - Kimberley Zell - Hotel

Rakefile.rb

@@ -0,0 +1,9 @@
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs = ["lib"]
+  t.warning = true
+  t.test_files = FileList['specs/*-specs.rb']
+end
+
+task default: :test

design-activity.md

@@ -0,0 +1,81 @@
+#What classes does each implementation include? Are the lists the same?
+
+Implementation A includes the following classes:
+CartEntry, ShoppingCart, Order
+
+Implementation B includes the following classes:
+CartEntry, ShoppingCart, Order
+
+The lists are the same.
+
+#Write down a sentence to describe each class.
+
+CartEntry adds an item to cart with the quantity and unit price.
+
+ShoppingCart holds a list of all items added to the cart.
+
+Order creates a new instance of ShoppingCart and can calculate the total price of the cart.
+
+
+How do the classes relate to each other? It might be helpful to draw a diagram on a whiteboard or piece of paper.
+
+An Order holds a ShoppingCart and its price.  A ShoppingCart holds all items entered for that cart. A CartEntry is used to create entries that will be added to the ShoppingCart.
+
+What data does each class store? How (if at all) does this differ between the two implementations?
+
+In A and B, CartEntry stores the unit price and quantity for an item.
+
+In A and B, ShoppingCart stores a list of entries.
+
+In A and B, Order stores SALES_TAX and a ShoppingCart.
+
+What methods does each class have? How (if at all) does this differ between the two implementations?
+
+A has the following methods for each class:
+CartEntry: initialize
+ShoppingCart: initialize
+Order: initialize, total_price
+
+B had the following:
+CartEntry: initialize, price
+ShoppingCart: initialize, price
+Order: initialize, total_price
+
+B has a method to calculate price for each class, rather than only one as in A.
+
+
+Consider the Order#total_price method. In each implementation:
+
+Is logic to compute the price delegated to "lower level" classes like ShoppingCart and CartEntry, or is it retained in Order?
+In B the logic to compute price is contained in lower level classes, but in A it is not - in A it is retained in Order.
+
+Does total_price directly manipulate the instance variables of other classes?
+
+In A it does.
+
+If we decide items are cheaper if bought in bulk, how would this change the code?
+
+In A it would be harder to change because we do not calculate price for each item separately in A.
+
+In B it would be easier to change, because we could add code to give an item discount when bought in bulk in the CartEntry class.  Since price is calculated for each item in CartEntry, the other classes would not be affected or have knowledge of this change.
+
+ Which implementation is easier to modify?
+
+ B is easier to modify.
+
+Which implementation better adheres to the single responsibility principle?
+
+B adheres better.
+
+Bonus question once you've read Metz ch. 3: Which implementation is more loosely coupled?
+
+B is more loosely coupled.
+
+# Identify one place in your Hotel project where a class takes on multiple roles, or directly modifies the attributes of another class.
+The Reservations class directly modifies attributes of other classes and overreaches in responsibility.  The other classes stick to single responsibility but Reservations does not and is much more complicated.  Reservations is too tightly coupled with other classes in several methods.
+
+# Describe in design-activity.md what changes you would need to make to improve this design, and how why the resulting design would be an improvement.
+
+I would remove direct calls on other classes in the methods as much as possible, and instead create instance variables on initialize within Reservations.  I would move as much as possible of the date checking, availability checking, date range creation, etc to the DateRange class.  I would have DateRange initialize with an array of dates rather than needing to call that method on a date range each time I need it.
+
+This would be an improvement because it would make the program more resilient to breaking if changes are made to other classes.  It would also make the code easier and less complicated to change in the future.

lib/Block.rb

@@ -0,0 +1,62 @@
+
+module Hotel
+  class Block < DateRange
+    attr_accessor :check_in, :check_out, :date_range, :dates, :block_rooms_collection, :discounted_room_rate, :available_rooms, :booked, :block_name, :number_of_rooms
+
+    def initialize(check_in, check_out, block_name, block_rooms_collection = [], discounted_room_rate = 180)
+
+      @check_in = Date.parse(check_in)
+      @check_out = Date.parse(check_out)
+      @date_range = Hotel::DateRange.new(check_in, check_out)
+      @dates = @date_range.dates
+      # @dates = Hotel::DateRange.new(@check_in, @check_out).dates
+      @block_rooms_collection = block_rooms_collection
+      @discounted_room_rate = discounted_room_rate
+      @booked = []
+      @block_name = block_name
+      # @number_of_rooms = number_of_rooms
+      # create_block_rooms_collection
+      # Hotel::Reservations.blocks_collection << Self
+    end
+
+    # def create_block_rooms_collection
+    #   unless @number_of_rooms <= 5 && @number_of_rooms >= 1
+    #     raise ArgumentError.new("Blocks can only have between 1 and 5 rooms.")
+    #   end
+    #   rooms_available = Hotel::Reservations.rooms_collection
+    #   @dates.each do |date|
+    #     Hotel::Reservations.list_reservations_by_date(date).each do |booking|
+    #       rooms_available.each do |room|
+    #         if room.room_number == booking.room_number
+    #           rooms_available.delete(room)
+    #         end
+    #       end
+    #     end
+    #   end
+    #   @block_rooms_collection = []
+    #
+    #   @number_of_rooms.times do |i|
+    #     @block_rooms_collection << rooms_available[i]
+    #   end
+    #   return @block_rooms_collection
+    # end
+
+    def validate_block_dates(check_in, check_out, block)
+      if check_in >= block.check_in && check_out <= block.check_out
+        return true
+      else
+        raise ArgumentError.new("Cannot reserve for those dates - dates must be the same as block dates.")
+      end
+    end
+
+    def has_rooms_available?
+      if !(@booked.length < @block_rooms_collection.length)
+        return false
+      else
+        return true
+      end
+    end
+
+
+  end
+end

lib/Booking.rb

@@ -0,0 +1,64 @@
+require 'date'
+require 'DateRange'
+
+module Hotel
+
+
+  class Booking < DateRange
+    attr_reader :check_in, :check_out, :room_number, :date_range
+    def initialize(check_in, check_out, room_number = rand(1..20), room_rate = 200)
+      @room_number = room_number
+      @check_in = Date.parse(check_in)
+      @check_out = Date.parse(check_out)
+      @date_range = DateRange.new(check_in, check_out)
+      @dates = @date_range.dates
+      @room_rate = room_rate
+      #@dates = Hotel::DateRange.new(check_in, check_out)
+      # @num_days = (@check_out - @check_in).to_i
+      # @total_cost = (@room_rate * @num_days)
+      @discount = 0
+
+      # validate_dates
+    end
+
+    # def validate_dates
+    #   unless @check_in >= Date.today
+    #     raise InvalidDateError.new("Check-in cannot be before today's date.")
+    #   end
+    #   unless @check_in < @check_out
+    #     raise InvalidDateError.new("Check-in cannot be after check-out.")
+    #   end
+    # end
+
+    def total_cost
+      num_days = (@check_out - @check_in).to_i
+      total_cost = @room_rate * num_days
+      return total_cost
+    end
+  end
+
+end
+
+# def available
+#   # greater than or equal than check_in date
+#   # and less than or equal to check_out date
+#   #
+#   # if the reservation dates contains the check_in date of an existing reservation it's already aproblem?
+#     @dates[0...-1].each do |date|
+#       list = Hotel::Reservations.list_reservations_by_date(date)
+#       list.each do |booking|
+#         if booking.room_number == room_number
+#           raise ArgumentError.new("Room number #{room_number} is not available for those dates.")
+#         end
+#       end
+#     end
+# end
+
+
+# def valid_dates
+#
+# unless card_is_valid?(card_number)
+# raise InvalidCardNumberError.new("Invalid credit card number #{card_number}")
+# end
+# # ... process the transaction ...
+# end