Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amy Lee -- Carets #37

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Amy Lee -- Carets #37

wants to merge 17 commits into from

Conversation

ayjlee
Copy link

@ayjlee ayjlee commented Nov 6, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I read through the (limited) documentation of the Edamam API on their website, made various HTTP requests in Postman, and ran tests using VCR to check the response body for different types of HTTP requests to the Edamam API.
Describe your API Wrapper. How did you decide on the methods you created? My Edamam API wrapper has methods to get Recipe results based on a given search term, as well as a method to to create a Recipe object based on the JSON response of the query, and then a find Recipe method to pull up information on one particular recipe, based on the unique key of the recipe's URI.
Describe an edge case or failure case test you wrote for your API Wrapper. I had to refactor my method to handle dealing with unauthorized requests as well as requests that don't have any results, because the response is different: either a html body response or an empty array.
Explain how VCR aids in testing an API. VCR save API requests and responses by groups called "cassettes". If the same request is made through your VCR testing, it will use the saved response instead of making a new API call. You can use the saved cassette responses to test for expected behavior and responses from your API wrapper methods.
What is the Heroku URL of your deployed application? https://ada-savor-app.herokuapp.com/

…lts), and show(recipe). added corresponding routes and placeholder views to home search page, index results page, and recipe show page
…rch_recipe_results to use the correctly formatted URL and return the array of newly created Recipe objects, modified Recipe controller to handle cases when no search term is entered, created basic orm for home search, created basic index page to show results as list
…ns an empty array for invalid requests based on the presence of the word 'error' in the response body from Edamam
@CheezItMan
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene You should do more granular commits, otherwise good commit messages
Comprehension questions Check
General
Rails fundamentals (RESTful routing, use of named paths) Check
Semantic HTML Well done
Errors are reported to the user No errors reported, you have the flash notices, but aren't displaying them
API Wrapper to handle the API requests Check
Controller testing Check
Lib testing Well done
Search Functionality Check
List Functionality Check
Show individual item functionality (link to original recipe opens in new tab) Check
Styling
Foundation Styling for responsive layout Well done
List View shows 10 items at a time/pagination Check
The app is styled to create an attractive user interface Very nicely styled
API Features
The App attributes Edaman Check
The VCR casettes do not contain the API key Check
External Resources
Link to deployed app on Heroku Check
Overall Well done, you hit all the requirements. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants