Kayla Ecker - Caret #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
Nov 7, 2017
| url = BASE_URL + "q=" + query + ID_AND_KEY + "&to=50" | ||
| data = HTTParty.get(url) | ||
| recipes = [] | ||
| unless data["hits"].empty? |
There was a problem hiding this comment.
You should have this check read
unless data["hits"].nil? || data["hits"].empty?
| <%= flash[:message] %> | ||
| </h3> | ||
| <%end%> | ||
| </div> |
There was a problem hiding this comment.
Need to fix alignment a bit, plus unnecessary div elements.
| <div class=name> | ||
| <%= link_to recipe.name, recipe_path(recipe.name, recipe_id: recipe.id)%> | ||
| </div> | ||
| <img src="<%= recipe.image %>", alt="<%= recipe.name %>"/> |
There was a problem hiding this comment.
making the image a link would be good as well.
| data = HTTParty.get(url) | ||
| recipe = "" | ||
| unless data.empty? | ||
| recipe = self.create_recipe(data[0]) |
There was a problem hiding this comment.
You should also check to see if data[0] has values
| it "succeeds when there are recipes for search" do | ||
| query = "apple" | ||
| VCR.use_cassette("search") do | ||
| EdamamApiWrapper.search(query).empty?.must_equal false |
There was a problem hiding this comment.
This is too specific to the wrapper. Let the controller make the wrapper call, focus on using the controller.
| must_respond_with :success | ||
| end | ||
| end | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions