-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stef -- Carets #24
base: master
Are you sure you want to change the base?
Stef -- Carets #24
Conversation
…ontact. More content creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some in-code comments
</head> | ||
|
||
<!-- Navigation Station and Contact/Social Media Links --> | ||
<div class="navbar"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML content should be in the body
section.
Also instead of using a div
element consider using a header
element here, it provides more semantic meaning to the content.
Good use of an unordered list for the menu.
</div> | ||
|
||
<!-- Background --> | ||
<body background="./images/cat.jpg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using the background
attribute for the background image, use CSS. This is old-style HTML.
</body> | ||
|
||
<!-- Footer --> | ||
<footer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly this should be inside the body
.
Static SiteWhat We're Looking For
|
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions