Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stef -- Carets #24

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Stef -- Carets #24

wants to merge 11 commits into from

Conversation

SesameSeeds
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I did not use one of these, I will look into it. I just refreshed a web page to check how things were working and kept it simple and as low stress as possible.
Why is it important to consider and use semantic HTML? It reinforces the meaning of the content on webpages through the use of its markup rather than its presentation which means theoretically that browsers and accessibility tools will benefit from the structure.
How did you decide to structure your CSS? I tend to structure my CSS in chunks from top to bottom in order of items. So everything in footer is clumped together, navigation bar, so on and so forth. I try to be simple about it because it can get long if you do a lot. No clue if I do it right, but I try to do what makes the most logical sense to me and appeals to my OCD.
What was the most challenging piece of this assignment? Simply doing it at all. I enjoyed it, but life made it difficult to do more than the basics and for that I apologize, but am glad I did something.
Describe one area that you gained more clarity on when completing this assignment I don't know if there is an area, but I am reinforcing that no matter what life throws my way, I can push through it even if I can't get to everything I want. On that note, I will flesh this out too as I can, I just really had an incredibly rough time doing anything this weekend and I apologize.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some in-code comments

</head>

<!-- Navigation Station and Contact/Social Media Links -->
<div class="navbar">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML content should be in the body section.

Also instead of using a div element consider using a header element here, it provides more semantic meaning to the content.

Good use of an unordered list for the menu.

</div>

<!-- Background -->
<body background="./images/cat.jpg">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using the background attribute for the background image, use CSS. This is old-style HTML.

</body>

<!-- Footer -->
<footer>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly this should be inside the body.

@CheezItMan
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Good number of commit, ok commit messages.
Answered comprehension questions Check, Using an HTML validator will help spot problems in your code and can make things easier. Also, don't apologize, do the best you can and let the work stand on it's own.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main You should probably convert your navigation div elements to headers, and they should be inside the body.
Appropriately using semantic tags: section, article, etc. Check
All images include alternate text No image tags so...
CSS Good use of nomalize.css
Using class and ID names in style declarations Check, you can probably convert .footer #copyright to #copyright in your main.css file since the ID is supposed to be unique.
Style declarations are DRY Some repeated rules like color: white, but that's minor.
Overall Not bad, you hit all the requirements. Some minor things I pointed out in the code, check the comments. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants