-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carets -- Guillermina #23
base: master
Are you sure you want to change the base?
Conversation
Static SiteWhat We're Looking For
|
Your indentation was a little off in a few places, and sometimes you weren't consistent about how you were opening and closing your tags between one line or multiple lines I appreciate that you created some empty tags for the practice of them (I understand your site isn't quite structured to have a "nav" or a "footer") :P But feel free to remove these. I could see a use for the also, good job making it mobile friendly! also... you knew this would happen but... I LOVE YOUR WEBSITE 🎉 😻 I T ' S S O G O O D ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ |
|
||
</nav> | ||
</header> | ||
<section class="header_box"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually can't find a use for this section and it's repeated on every page
|
||
|
||
<section class="photo_box"> | ||
<article id="index"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might actually be a good use case for not using <article>
but instead using <div>
<a href="../assets/overwatch_guess.gif"><img src="../assets/overwatch_guess.gif" alt="overwatch guessing game"/></a> | ||
<h3>HTML&CSS</h3> | ||
<a href="../assets/waow_meow.gif"><img src="../assets/waow_meow.gif" alt="meowspace website"></a> | ||
<a href="../assets/personal_page.gif"><img src="../assets/personal_page.gif"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the one img tag you forgot some alt text for!
<img src="../assets/strawberries.png"/> | ||
<h3></h3> | ||
<p>well what is happening</p> | ||
</article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watch your indentation!
|
||
</section> | ||
<section class="main_box"> | ||
<h2>hi i'm guillermina muro,</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can probably make this an <h1>
instead of an h2 and style it the way you want to. h1 is for the most important information on the page, which this is
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions