Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets -- Guillermina #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Carets -- Guillermina #23

wants to merge 5 commits into from

Conversation

murog
Copy link

@murog murog commented Sep 18, 2017

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? The HTML validator said my articles/sections did not include headers. However, I preferred for them to not have headers.
Why is it important to consider and use semantic HTML? To clearly define the contents of the web page.
How did you decide to structure your CSS? By class.
What was the most challenging piece of this assignment? Designing a layout that worked on multiple screen sizes.
Describe one area that you gained more clarity on when completing this assignment Absolute, Relative and Static Positioning.

@tildeee
Copy link

tildeee commented Oct 3, 2017

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage wish you went more in depth!
Answered comprehension questions wish you went more in depth!
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main non-conventional website, so didn't have these :)
Appropriately using semantic tags: section, article, etc. x
All images include alternate text missing one of them
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

@tildeee
Copy link

tildeee commented Oct 3, 2017

Your indentation was a little off in a few places, and sometimes you weren't consistent about how you were opening and closing your tags between one line or multiple lines

I appreciate that you created some empty tags for the practice of them (I understand your site isn't quite structured to have a "nav" or a "footer") :P But feel free to remove these. I could see a use for the <main> tag though, which you didn't use (as you used <section> instead)

also, good job making it mobile friendly!

also... you knew this would happen but... I LOVE YOUR WEBSITE 🎉 😻 I T ' S S O G O O D

✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨


</nav>
</header>
<section class="header_box">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually can't find a use for this section and it's repeated on every page



<section class="photo_box">
<article id="index">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might actually be a good use case for not using <article> but instead using <div>

<a href="../assets/overwatch_guess.gif"><img src="../assets/overwatch_guess.gif" alt="overwatch guessing game"/></a>
<h3>HTML&CSS</h3>
<a href="../assets/waow_meow.gif"><img src="../assets/waow_meow.gif" alt="meowspace website"></a>
<a href="../assets/personal_page.gif"><img src="../assets/personal_page.gif"></a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the one img tag you forgot some alt text for!

<img src="../assets/strawberries.png"/>
<h3></h3>
<p>well what is happening</p>
</article>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch your indentation!


</section>
<section class="main_box">
<h2>hi i'm guillermina muro,</h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can probably make this an <h1> instead of an h2 and style it the way you want to. h1 is for the most important information on the page, which this is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants