Rest/master #16
Open
Rest/master #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth Dev Portal Created, FontAwesome added
login page buttons added
now only the user sees the search bar if they're logged in
We can follow creators :-)
| if creator.nil? | ||
| flash[:error] = "Failed to follow" | ||
| else | ||
| if !@current_user.creators.include?(creator) |
There was a problem hiding this comment.
According to the Ruby Style Guide, it is the preferred way to use unless instead of negative if conditionals.
Ex:
unless @current_user.creators.include?(creator)You can find the Ruby Style Guide here
|
Great work on this project! Yay for APIs!!! Look at all this cool code logic you're using to create awesome things! A few minor things to keep working on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.