Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minizip seems to be changing to a hex number for MZ_VERSION_BUILD #1954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

opoplawski
Copy link

This hasn't been released yet but:

zlib-ng/minizip-ng@a7d612a
zlib-ng/minizip-ng#758

Copy link

linux-foundation-easycla bot commented Mar 4, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing a fix, but does it actually work with all releases of minizip-ng? Maybe we need to switch to parsing MZ_VERSION rather than trying to deal with their switching MZ_VERSION_BUILD from decimal to octal to hex?

Linking issue #1818 for reference.

@markreidvfx
Copy link
Contributor

I think we should parse MZ_VERSION instead too. MZ_VERSION_BUILD will be too unreliable going forward.

@markreidvfx
Copy link
Contributor

The cmake module that detects minizip does parse the MZ_VERSION from mz.h as minizip-ng_VERSION. So it should be just a matter of extracting the major version and creating a macro definition for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants