Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: ocioarchive enhancements #1931

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

DRAFT: ocioarchive enhancements #1931

wants to merge 8 commits into from

Commits on Jan 22, 2024

  1. Add function to return list of all external files in a config 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b796a6f View commit details
    Browse the repository at this point in the history

  2. Add basic Archive flags for configuring archiving 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4869a87 View commit details
    Browse the repository at this point in the history

  3. Add global comment to archives to record OCIO version used to create … 

    …them

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a115736 View commit details
    Browse the repository at this point in the history

  4. Add Basic minimal archive functionallity 

    Needs documenting and testing
May be nice to have a progress report and/or integration with OCIO Logging

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    54121ce View commit details
    Browse the repository at this point in the history

  5. Add support for environment variables in minimal configuration archives 

    If archiving a minimal config and environment variables are used, it must be possible for all the needed variables to be resolved and any files pointed to should also exist at the time of archiving.

The values of the environment will be written into the saved configuration in the environment section of the configuration file. Ths configuration stored thus may be different to the initial config being passed for archiving.

Needs tests adding and futher discussion in the TSC meetings.

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c727983 View commit details
    Browse the repository at this point in the history

  6. Add minimal code to make the python tests pass 

    Adds default parameter value for isArchivable function to bindings. This is not matching the behaviour of the C++ API.

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8671def View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Add minimal boolean to lambda captures for MSVC 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ec3e761 View commit details
    Browse the repository at this point in the history

  2. Rework lambda to pass MSVC and GCC 

    MSVC thinks you need the capture, GCC thinks the capture is not  needed, so pass variable directly into the lambda function call. Ugly to pass several booleans, but should work.

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    94a0221 View commit details
    Browse the repository at this point in the history