Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching python unittest to pytest framework #1739

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Switching python unittest to pytest framework #1739

wants to merge 8 commits into from

Commits on Jan 25, 2023

  1. Switching python unittest to pytest framework 

    This change may also have a small naming requirement as we can see in the pyproject.toml.
It prompted me to change the helper function name from test_percent_1000() to helper_test_percent_1000 since pytest config will now discover every functions starting with test_*. However, I thought it may still be worth the switch for possible pytest features we can leverage down the road.
Just wanted to see what the thought is on switching and the changes in config. May need to change the docs/guides/contributing/unit_tests.rst to reflect this config change as well.

Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d23173b View commit details
    Browse the repository at this point in the history

  2. Adding more pytest options into pyproject.toml. 

    Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b94df2c View commit details
    Browse the repository at this point in the history

  3. -Set minimum version of pytest to 6 to support myproject.toml. 

    Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1d86e1e View commit details
    Browse the repository at this point in the history

  4. - Added pytest.ini as an older pytest config file. 

    Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    6d9e3c8 View commit details
    Browse the repository at this point in the history

  5. -Removed pytest version requirement because python2 support is droppe… 

    …d before pytest version 5.

Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    293ac11 View commit details
    Browse the repository at this point in the history

  6. -Add pytest to wheel test requirement. 

    Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    c384532 View commit details
    Browse the repository at this point in the history

  7. -Remove pytest.ini. 

    -Remove pytest component of pyproject.toml.
-Conform tests to pytest naming convention.

Signed-off-by: Mei Chu <[email protected]>
    @meimchu
    meimchu committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7c9d6ab View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Merge branch 'main' into python-unittest-to-pytest

    @remia
    remia authored Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ad08648 View commit details
    Browse the repository at this point in the history