Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding all Art-Net packets #15

Merged
merged 53 commits into from
Aug 17, 2023
Merged

Adding all Art-Net packets #15

merged 53 commits into from
Aug 17, 2023

Conversation

minorDeveloper
Copy link
Contributor

Adding all packets as defined by the Art-Net 4 specification

Vitineth and others added 24 commits July 20, 2023 20:07
@Vitineth
Adding first batch of ksy files
2d63611 
These cover with documentation pulled from the spec itself. These are as of yet not tested thoroughly but will gradually be updated with fixes

* artaddress
* arddiagdata
* artipprog
* artipprogreply
* artpoll
* artpollreply
@Vitineth
Adding first batch of ksy files
8f87b43 
These cover with documentation pulled from the spec itself. These are as of yet not tested thoroughly but will gradually be updated with fixes

* artaddress
* arddiagdata
* artipprog
* artipprogreply
* artpoll
* artpollreply
@Vitineth
Merge remote-tracking branch 'origin/vitineth/artnet-ksy' into vitine…
aec17b1 
…th/artnet-ksy
@Vitineth
Adding verbose output for better logging
6e903c7
@Vitineth
Adding four new specification files
69fba29
@Vitineth
Adding titles to all existing files
71b0578
@Vitineth
Two new packet types! 9 more definitions to go
463f184
@theMinorDeveloper
ArtTodRequest
4d3e367
@theMinorDeveloper
Tab fixes
ef26a3a
@theMinorDeveloper
ArtTodRequest tabs
774b32c
@Vitineth
Rapidly fixing some docs
eb51984
@Vitineth
Adding ArtVlc
33118af
@Vitineth
Fixing a recommendation from ksc
3a391ba
@Vitineth
Adding ArtInput and ArtFirmwareMaster
1bb4087
@Vitineth
Removing pre-built html
eef6770
@Vitineth
Adding ArtFirmwareReply
9938354
@Vitineth
Adding the firmware format even though its not a packet
e33f1f0
@minorDeveloper
Setting DMX array min and max
a939dc4 
Min = 2, max = 512
@theMinorDeveloper
Adding ArtTodData
46af3a3
@theMinorDeveloper
Adding ArtTodControl
a5accdf
@theMinorDeveloper
Adding ArtRdm
c112e91
@theMinorDeveloper
Adding ArtRdmSub
8716719
@theMinorDeveloper
Migrating RDM UID to custom type
7b8c403
@theMinorDeveloper
Merge remote-tracking branch 'origin/vitineth/artnet-ksy' into vitine…
90b16d1 
…th/artnet-ksy
@minorDeveloper minorDeveloper added the enhancement New feature or request label Aug 3, 2023
@minorDeveloper minorDeveloper added this to the Artnet milestone Aug 3, 2023
@minorDeveloper minorDeveloper requested a review from Vitineth August 3, 2023 17:20
Vitineth
Vitineth requested changes Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@Vitineth Vitineth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks, some major fixes required. See comments above, will re-review after changes complete.

artnet/ksy/artcommand.ksy Show resolved Hide resolved
artnet/ksy/artcommand.ksy Outdated Show resolved Hide resolved
artnet/ksy/artcommand.ksy Outdated Show resolved Hide resolved
artnet/ksy/artdiagdata.ksy Outdated Show resolved Hide resolved
artnet/ksy/artdiagdata.ksy Show resolved Hide resolved
artnet/ksy/arttodrequest.ksy Outdated Show resolved Hide resolved
artnet/ksy/arttodrequest.ksy Outdated Show resolved Hide resolved
artnet/ksy/arttrigger.ksy Outdated Show resolved Hide resolved
artnet/ksy/artvlc.ksy Show resolved Hide resolved
artnet/ksy/artvlc.ksy Outdated Show resolved Hide resolved
Vitineth and others added 23 commits August 5, 2023 14:31
@Vitineth
Adding EstaMan and Oem
1ee0734 
Needs testing due to the added consuming expression. 

Per #15 (comment)
@Vitineth
Adding clarity
d89f4b7 
Per #15 (comment)
@Vitineth
Fixing port address on ArtPollReply
6a85903 
Per #15 (comment)
@Vitineth
Integer to array for SwIn/Out in ArtPollReply
5e16b0b 
Per #15 (comment)
@Vitineth
Adding missing fields to ArtPollReply
86cc808 
Per #15 (comment)
@Vitineth
Fixing field length in ArtPollReply
a997c98 
Per #15 (comment)
@Vitineth
Simplifying Aux in ArtSync
dcc4320 
Per #15 (comment)
@Vitineth
Mandating VLC magic number in ArtVlc
d531d94 
Per #15 (comment)
@Vitineth
Removing invalid field in ArtVlc
1755a22 
Per #15 (comment)
@Vitineth
Removing note that is now invalid
ba1294b 
Per #15 (comment)
@Vitineth
Merge remote-tracking branch 'origin/vitineth/artnet-ksy' into vitine…
a336fc3 
…th/artnet-ksy
@Vitineth
Reverting change to Port Address on ArtPollReply
7fe2943 
Per #15 (comment)
@Vitineth
Adding some extra documentation about sizing
50aea39
@minorDeveloper
Setting max value for len_address
781f816
@minorDeveloper
Port documentation formatting
2e50f85
@minorDeveloper
Tabs formatting fix
96f5ea6
@minorDeveloper
Remove html file
d8418c9
@minorDeveloper
Migrating to flexible RDM packet size
fc7985c
@minorDeveloper
Enforcing max data size for ArtTrigger
c181825
@Vitineth
Converting handling rules into tables
e7c3f13
@Vitineth
Merge remote-tracking branch 'origin/vitineth/artnet-ksy' into vitine…
a28e188 
…th/artnet-ksy
@Vitineth
Making flags and diagpriority non-option in ArtPoll
d3dff39
@Vitineth
Making spare, style and mac required in ArtPollReply
027382d
@Vitineth Vitineth mentioned this pull request Aug 8, 2023
Open
Vitineth
Vitineth approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Vitineth Vitineth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (but skeptically) until we have actual data to test with

@minorDeveloper minorDeveloper merged commit 0b334e4 into main Aug 17, 2023
@Vitineth Vitineth deleted the vitineth/artnet-ksy branch September 27, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vitineth Vitineth Vitineth approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Lighting Protocols Roadmap
Status: In Progress
Milestone
Artnet
Development

Successfully merging this pull request may close these issues.
3 participants
@minorDeveloper @Vitineth @theMinorDeveloper