nested navigation menu items #2609

sadaf895 · 2024-10-09T14:30:24Z

github-actions · 2024-10-09T14:30:42Z

Deployed to https://pr-2609.aam-digital.net/

sleidig

@sadaf895 , let us look at the permission aspects together in a joint session

src/app/core/config/dynamic-routing/route-permissions.service.ts

…parately (#2616) closes #2587

Snyk has created this PR to upgrade webpack from 5.94.0 to 5.95.0. See this package in npm: https://www.npmjs.com/package/webpack See this project in Snyk: https://app.snyk.io/org/aam-digital-ci/project/a4b5c50c-28f4-4e30-af2d-840962b9beaf?utm_source=github&utm_medium=referral&page=upgrade-pr

including storybook migrations to CSF3 format

…quired

fixes #2618

…widget (#2575) now displays multiple groupBy for different fields in a single widget closes #2557 Co-authored-by: Sebastian Leidig <[email protected]>

also see #2339

closes #2638

fixes #2615

…#2649) fixes #2647

…verwritable via config (#2656) closes #2594

Co-authored-by: sadaf895 <[email protected]>

fixes #2659 --------- Co-authored-by: Sebastian <[email protected]>

src/app/core/config/dynamic-routing/route-permissions.service.ts

src/app/core/ui/navigation/menu-item.component.ts

src/app/core/ui/navigation/navigation/navigation.component.ts

sleidig

Seems to work well now

sadaf895 · 2024-11-20T10:25:20Z

It is working for me now, @sleidig Let me know that whether it is working well for you also.

…b-core into Nested_menu_items

src/app/core/config/dynamic-routing/route-permissions.service.spec.ts

…spec.ts

…b-core into Nested_menu_items

and remove unused code

aam-digital-ci · 2024-11-25T11:02:39Z

🎉 This PR is included in version 3.43.0-master.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

aam-digital-ci · 2024-11-25T16:46:04Z

🎉 This PR is included in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

created storybook component and written code for testing the result.

0ad9508

sleidig changed the title ~~created storybook component and written code for testing the result.~~ nested navigation menu items Oct 11, 2024

sadaf895 added 4 commits October 11, 2024 22:48

Written the html and ts file code.

cf98f89

initial commit

7126967

created component that include one icon+label+submenu

dae10b0

Improved the UI.

307465d

sadaf895 marked this pull request as ready for review October 17, 2024 14:31

sleidig reviewed Oct 18, 2024

View reviewed changes

src/app/core/config/dynamic-routing/route-permissions.service.ts Outdated Show resolved Hide resolved

sleidig linked an issue Nov 15, 2024 that may be closed by this pull request

nested / hierarchical menu items #2249

Closed

tomwwinter and others added 20 commits November 15, 2024 16:06

fix: prevent component init error (#2620)

a89ae95

fix(attendance): attendance overview tab lists archived activities se…

87f8ab0

…parately (#2616) closes #2587

fix(deps): update dependencies and upgrade storybook

4f4779b

including storybook migrations to CSF3 format

fix(Template Export): required filename pattern field is marked as re…

3b11a7e

…quired

fix: prevent error when attempting to log details of failed to fetch

cbc7ae1

fix: ensure base types like Note are migrated

2b46c4d

fix(attendance): display absent participants even if added via group

e830920

fixes #2618

fix(dashboard): improve UI and performance of count & disaggregation …

e7b8c7c

…widget (#2575) now displays multiple groupBy for different fields in a single widget closes #2557 Co-authored-by: Sebastian Leidig <[email protected]>

fix(i18n): update translations

2e8aaef

refactor: remove old config migrations (#2536)

fcbc9ef

also see #2339

fix(dashboard): improve layout of entity-count widget (#2643)

ad17bab

closes #2638

fix: attendance status now always reliably saved (#2641)

c8fdb94

fixes #2615

fix: dashboard widget shows correct number excluding inactive records (…

eca9dd7

…#2649) fixes #2647

ci: use internal server for chrome downloads (#2658)

cded9be

feat(core): make subtitle and explanation for all dashboard widgets o…

e0e2298

…verwritable via config (#2656) closes #2594

fix: prevent duplicate keys in filter options (#2640)

4a05ce6

Co-authored-by: sadaf895 <[email protected]>

fix: progress dashboard shows correct overall percentage again (#2663)

c0650b6

fixes #2659 --------- Co-authored-by: Sebastian <[email protected]>

add recursive menu item permission checks

4b81273

Merge branch 'master' into Nested_menu_items

28a4747

sleidig reviewed Nov 15, 2024

View reviewed changes

src/app/core/config/dynamic-routing/route-permissions.service.ts Show resolved Hide resolved

Update src/app/core/config/dynamic-routing/route-permissions.service.ts

485a525

sleidig reviewed Nov 15, 2024

View reviewed changes

src/app/core/ui/navigation/menu-item.component.ts Outdated Show resolved Hide resolved

sleidig reviewed Nov 15, 2024

View reviewed changes

src/app/core/ui/navigation/navigation/navigation.component.ts Outdated Show resolved Hide resolved

Update src/app/core/ui/navigation/navigation/navigation.component.ts

1f5f1be

sleidig reviewed Nov 15, 2024

View reviewed changes

src/app/core/ui/navigation/navigation/navigation.component.ts Outdated Show resolved Hide resolved

config menu

459053c

sleidig approved these changes Nov 15, 2024

View reviewed changes

sadaf895 added 2 commits November 18, 2024 14:07

removed unnecessary import

ce8657a

Pass the activeLink as an @input to menu component

4e642ed

sadaf895 and others added 4 commits November 20, 2024 16:37

Revert the variable name to link.

5776df4

Merge branch 'master' into Nested_menu_items

662af98

removed " as string"

2fe2c1d

Merge branch 'Nested_menu_items' of https://github.com/Aam-Digital/nd…

4f44047

…b-core into Nested_menu_items

sleidig reviewed Nov 20, 2024

View reviewed changes

src/app/core/config/dynamic-routing/route-permissions.service.spec.ts Outdated Show resolved Hide resolved

sleidig and others added 8 commits November 20, 2024 18:20

Update src/app/core/config/dynamic-routing/route-permissions.service.…

309fc26

…spec.ts

Implement logic for active submenu

ecf35e3

Merge branch 'Nested_menu_items' of https://github.com/Aam-Digital/nd…

0b9a4ea

…b-core into Nested_menu_items

move to own component folder

3550a40

Merge branch 'master' into Nested_menu_items

23d225e

remove test config

f4b3a09

clarify code comments

37e2d17

and remove unused code

fix submenu highlighting

d622c4d

sleidig merged commit 7b788aa into master Nov 25, 2024
13 checks passed

sleidig deleted the Nested_menu_items branch November 25, 2024 09:57

aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 25, 2024

aam-digital-ci added the released managed by CI (semantic-release) label Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nested navigation menu items #2609

nested navigation menu items #2609

sadaf895 commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024

sleidig left a comment

sleidig left a comment

sadaf895 commented Nov 20, 2024

aam-digital-ci commented Nov 25, 2024

aam-digital-ci commented Nov 25, 2024

nested navigation menu items #2609

nested navigation menu items #2609

Conversation

sadaf895 commented Oct 9, 2024 • edited Loading

github-actions bot commented Oct 9, 2024

sleidig left a comment

Choose a reason for hiding this comment

sleidig left a comment

Choose a reason for hiding this comment

sadaf895 commented Nov 20, 2024

aam-digital-ci commented Nov 25, 2024

aam-digital-ci commented Nov 25, 2024

sadaf895 commented Oct 9, 2024 •

edited

Loading