Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all traces of Address #89

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove all traces of Address #89

merged 1 commit into from
Oct 16, 2024

Conversation

KrashKart
Copy link

Fixes #83

@KrashKart KrashKart added type.Chore Something that needs to be done, but not a story, bug, or an epic. priority.Low Unlikely to do severity.Low A flaw that is unlikely to affect normal operations of product. Rare problem, minor inconvenience. labels Oct 16, 2024
@KrashKart KrashKart added this to the v1.4 milestone Oct 16, 2024
@KrashKart KrashKart self-assigned this Oct 16, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/main/java/seedu/address/model/person/Person.java 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 85.71% <ø> (-1.79%) 3.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 97.18% <100.00%> (-0.26%) 13.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 80.00% <ø> (-3.34%) 1.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 92.00% <100.00%> (-0.60%) 10.00 <0.00> (-1.00)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.77% <ø> (-0.45%) 12.00 <0.00> (-2.00)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø) 9.00 <0.00> (-2.00)
...c/main/java/seedu/address/model/person/Person.java 90.00% <66.66%> (+1.11%) 27.00 <0.00> (-2.00) ⬆️

CYX22222003
CYX22222003 approved these changes Oct 16, 2024
View reviewed changes
Copy link

@CYX22222003 CYX22222003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Address is irrelevant to our product value proposition. All traces of address have been removed from main classes and test.

@KrashKart KrashKart merged commit cfc8d74 into AY2425S1-CS2103T-F14a-4:master Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CYX22222003 CYX22222003 CYX22222003 approved these changes

Assignees

@KrashKart KrashKart

Labels
priority.Low Unlikely to do severity.Low A flaw that is unlikely to affect normal operations of product. Rare problem, minor inconvenience. type.Chore Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Remove all traces of Address
2 participants
@KrashKart @CYX22222003