Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit test for duplicate information detection #75

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update unit test for duplicate information detection #75

merged 2 commits into from
Oct 16, 2024

Conversation

CYX22222003
Copy link

@CYX22222003 CYX22222003 commented Oct 15, 2024 •
edited
Loading

Fix #62

Adding more test cases for duplicate information check.
Update UniquePersonList to prevent edit and add person with duplicated information.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 9 files with indirect coverage changes

@CYX22222003 CYX22222003 marked this pull request as ready for review October 15, 2024 16:22
@CYX22222003 CYX22222003 self-assigned this Oct 15, 2024
@CYX22222003 CYX22222003 added this to the v1.3 milestone Oct 15, 2024
KrashKart
KrashKart approved these changes Oct 16, 2024
View reviewed changes
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should be sufficient to check for same number and duplicate information

@KrashKart KrashKart merged commit 2773f7c into AY2425S1-CS2103T-F14a-4:master Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrashKart KrashKart KrashKart approved these changes

@chrisjohntan chrisjohntan Awaiting requested review from chrisjohntan

@yooplo yooplo Awaiting requested review from yooplo

@blackpanther9229 blackpanther9229 Awaiting requested review from blackpanther9229

Assignees

@CYX22222003 CYX22222003

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Add more test cases for duplicate personal details checks
2 participants
@CYX22222003 @KrashKart