Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all instances of 'AddressBook' with 'CampusConnect' #74

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Replace all instances of 'AddressBook' with 'CampusConnect' #74

merged 3 commits into from
Oct 15, 2024

Conversation

yooplo
Copy link

@yooplo yooplo commented Oct 15, 2024

No description provided.

@yooplo yooplo added this to the v1.3 milestone Oct 15, 2024
@yooplo yooplo requested a review from KrashKart October 15, 2024 10:40
@yooplo yooplo linked an issue Oct 15, 2024 that may be closed by this pull request
Rename AB3 packages / classes to CampusConnect #65
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 9 Missing ⚠️
...rc/main/java/seedu/address/logic/LogicManager.java 60.00% 2 Missing ⚠️
...c/main/java/seedu/address/model/CampusConnect.java 66.66% 0 Missing and 1 partial ⚠️
src/main/java/seedu/address/model/UserPrefs.java 87.50% 1 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 1 Missing ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...in/java/seedu/address/commons/core/LogsCenter.java 78.78% <ø> (ø) 5.00 <0.00> (ø)
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...eedu/address/logic/parser/CampusConnectParser.java 100.00% <100.00%> (ø) 12.00 <1.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <100.00%> (ø) 23.00 <8.00> (ø)
...eedu/address/storage/JsonCampusConnectStorage.java 100.00% <100.00%> (ø) 8.00 <8.00> (?)
...address/storage/JsonSerializableCampusConnect.java 100.00% <100.00%> (ø) 4.00 <3.00> (?)
...ain/java/seedu/address/storage/StorageManager.java 94.44% <100.00%> (ø) 9.00 <4.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 6 more

KrashKart
KrashKart approved these changes Oct 15, 2024
View reviewed changes
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KrashKart KrashKart added type.Chore Something that needs to be done, but not a story, bug, or an epic. priority.Medium Nice to have labels Oct 15, 2024
@yooplo
Merge branch 'master' into branch-rename-packages
67fb76a 
# Conflicts:
#	src/test/java/seedu/address/logic/commands/FindCommandTest.java
@KrashKart
Copy link

KrashKart commented Oct 15, 2024 •
edited
Loading

delete the FindCommandTest.java file entirely, checkstyle throwing error

@yooplo yooplo merged commit 4905482 into AY2425S1-CS2103T-F14a-4:master Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrashKart KrashKart KrashKart approved these changes

Assignees
No one assigned
Labels
priority.Medium Nice to have type.Chore Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Rename AB3 packages / classes to CampusConnect
2 participants
@yooplo @KrashKart