Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find contacts by tag #71

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

KrashKart
Copy link

Fixes #66

Let's
* add the FindByTagCommand class to find by tag
* TagContainsKeywordsPredicate with naive finding
@KrashKart KrashKart added type.Story A user story priority.High Must do labels Oct 15, 2024
@KrashKart KrashKart added this to the v1.3 milestone Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...seedu/address/logic/commands/FindByTagCommand.java 75.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...du/address/logic/commands/AbstractFindCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...eedu/address/logic/commands/FindByNameCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 82.35% <100.00%> (-1.86%) 7.00 <0.00> (+1.00) ⬇️
...ess/model/person/TagContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...seedu/address/logic/commands/FindByTagCommand.java 75.00% <75.00%> (ø) 3.00 <3.00> (?)

Copy link

@yooplo yooplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This should correctly implement the finding of contacts by their tag.

@yooplo yooplo merged commit 9ca011b into AY2425S1-CS2103T-F14a-4:master Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all the contacts with the same tag
2 participants