Branch update find command format #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original was /<tag> now is <tag>/ To make it in uniform with the other commands
Include additional test cases
KrashKart
approved these changes
Oct 15, 2024
| @@ -17,7 +16,7 @@ public ContactContainsKeywordsPredicate(List<String> keywords) { | |||
| @Override | |||
| public boolean test(Person person) { | |||
| return this.getKeywords().stream() | |||
| .anyMatch(keyword -> StringUtil.containsWordIgnoreCase(person.getPhone().value, keyword)); | |||
| .anyMatch(keyword -> person.getPhone().value.toLowerCase().contains(keyword.toLowerCase())); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Can keep in view to possibly abstract the test method into the superclass FindCommand if we decide to extend the logic
| return new FindByContactCommand( | ||
| new ContactContainsKeywordsPredicate(Arrays.asList(searchTermArray))); | ||
| case "/e": | ||
| case "e/": | ||
| return new FindByEmailCommand( | ||
| new EmailContainsKeywordsPredicate(Arrays.asList(searchTermArray))); | ||
| default: |
There was a problem hiding this comment.
Can keep in view to shorten the code here by establishing Arrays.asList(....) outside the switch so we do not have to type this 3 times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update find command tag from '/' to '/'
Improved finding to include results with partial matches
Include additional test cases
Closes #63