Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for duplicate phone number #60

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Check for duplicate phone number #60

merged 3 commits into from
Oct 10, 2024

Conversation

chrisjohntan
Copy link

Closes #44

@chrisjohntan chrisjohntan added this to the v1.2 milestone Oct 10, 2024
@chrisjohntan chrisjohntan self-assigned this Oct 10, 2024
KrashKart
KrashKart approved these changes Oct 10, 2024
View reviewed changes
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Implementation sufficiently checks if the person has the same email, phone number or name

@KrashKart KrashKart merged commit 779c744 into AY2425S1-CS2103T-F14a-4:master Oct 10, 2024
3 checks passed
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/main/java/seedu/address/model/person/Person.java 50.00% 0 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ Complexity Δ
...c/main/java/seedu/address/model/person/Person.java 84.44% <50.00%> (-3.66%) 27.00 <5.00> (+2.00) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrashKart KrashKart KrashKart approved these changes

Assignees

@chrisjohntan chrisjohntan

Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Check for duplicate phone number
2 participants
@chrisjohntan @KrashKart