Implement filtering of contacts by number #56

KrashKart · 2024-10-10T05:40:06Z

Fixes #47

Let's * implement FindByContact * change AddressBookParserTest, FindCommandParser unit tests * add unit test for FindByContact * tidy code for checkstyle

For FindByContactCommand and FindByNameCommand

codecov · 2024-10-10T06:01:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ	Complexity Δ
...u/address/logic/commands/FindByContactCommand.java	`100.00% <100.00%> (ø)`	`4.00 <4.00> (?)`
...eedu/address/logic/commands/FindByNameCommand.java	`100.00% <ø> (ø)`	`4.00 <0.00> (ø)`
.../seedu/address/logic/parser/FindCommandParser.java	`82.35% <100.00%> (+2.35%)`	`5.00 <0.00> (+1.00)`

... and 1 file with indirect coverage changes

src/main/java/seedu/address/logic/commands/FindByContactCommand.java

yooplo · 2024-10-10T07:23:59Z

src/test/java/seedu/address/logic/commands/FindByContactCommandTest.java

+/**
+ * Contains integration tests (interaction with the Model) for {@code FindByContactCommand}.
+ */
+public class FindByContactCommandTest {


Good test coverage

yooplo · 2024-10-10T07:39:04Z

src/main/java/seedu/address/logic/commands/FindByNameCommand.java

+    public static final String MESSAGE_USAGE = COMMAND_WORD + ": Finds all persons whose names "
+            + "contain any of the specified keywords (case-insensitive) and displays them as a list with indices.\n"
+            + "Parameters: KEYWORD [MORE_KEYWORDS]...\n"
+            + "Example: " + COMMAND_WORD + " alice bob charlie";
    public FindByNameCommand(NameContainsKeywordsPredicate predicate) {


yep that works

Make the error message more appropriate for contact numbers

Test for the correct MESSAGE_USAGE

This is infuriatingly dumb

yooplo

good to go

KrashKart added 3 commits October 10, 2024 12:49

Add class file for FindByContactCommand

d478e3d

Merge branch 'master' into branch-Find-Contact

b8afc39

Add FindByContactCommand

86973cd

Let's * implement FindByContact * change AddressBookParserTest, FindCommandParser unit tests * add unit test for FindByContact * tidy code for checkstyle

KrashKart added type.Enhancement An enhancement to an existing story priority.High Must do labels Oct 10, 2024

KrashKart added this to the v1.2 milestone Oct 10, 2024

KrashKart self-assigned this Oct 10, 2024

KrashKart added 2 commits October 10, 2024 13:49

Add command word and message usage

2e31ac5

For FindByContactCommand and FindByNameCommand

Fix unit test

e3f5738

KrashKart marked this pull request as ready for review October 10, 2024 06:04

KrashKart requested a review from yooplo October 10, 2024 06:09

yooplo reviewed Oct 10, 2024

View reviewed changes

KrashKart added 4 commits October 10, 2024 16:06

Update error message for FindByContactCommand

2c0ea77

Make the error message more appropriate for contact numbers

Change unit test for FindCommandParserTest

d5ff881

Test for the correct MESSAGE_USAGE

Remove unused import

f321113

This is infuriatingly dumb

Remove unused imports

723a527

yooplo approved these changes Oct 10, 2024

View reviewed changes

CYX22222003 merged commit a48b49b into AY2425S1-CS2103T-F14a-4:master Oct 10, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement filtering of contacts by number #56

Implement filtering of contacts by number #56

KrashKart commented Oct 10, 2024

codecov bot commented Oct 10, 2024 •

edited

Loading

yooplo Oct 10, 2024

yooplo Oct 10, 2024

yooplo left a comment

Implement filtering of contacts by number #56

Implement filtering of contacts by number #56

Conversation

KrashKart commented Oct 10, 2024

codecov bot commented Oct 10, 2024 • edited Loading

Codecov Report

yooplo Oct 10, 2024

Choose a reason for hiding this comment

yooplo Oct 10, 2024

Choose a reason for hiding this comment

yooplo left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 10, 2024 •

edited

Loading