-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FindEmailCommand class #55
Implement FindEmailCommand class #55
Conversation
closes issue #46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This should enable us to find by email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge sort
+ "Example:\n" | ||
+ COMMAND_WORD + " " + FIND_NAME_COMMAND_WORD + " alice bob charlie\n" | ||
+ COMMAND_WORD + " " + FIND_CONTACT_COMMAND_WORD + " [CONTACT NUMBER]\n" | ||
+ COMMAND_WORD + " " + FIND_EMAIL_COMMAND_WORD + " [email protected]"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sufficient for a general instruction to guide the user
return false; | ||
} | ||
return super.predicate.equals(otherFindCommand.predicate); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps can keep in view to use this.getPredicate() instead of directly accessing the super.predicate field although it is allowed (or remove the getPredicate() entirely, undecided as of now)
No description provided.