Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FindEmailCommand class #55

Closed

Conversation

yooplo
Copy link

@yooplo yooplo commented Oct 10, 2024

No description provided.

@yooplo yooplo added this to the v1.2 milestone Oct 10, 2024
@yooplo yooplo requested a review from KrashKart October 10, 2024 04:31
@yooplo yooplo self-assigned this Oct 10, 2024
@yooplo yooplo linked an issue Oct 10, 2024 that may be closed by this pull request
@yooplo
Copy link
Author

yooplo commented Oct 10, 2024

closes issue #46

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...edu/address/logic/commands/FindByEmailCommand.java 71.42% 1 Missing and 1 partial ⚠️
.../seedu/address/logic/parser/FindCommandParser.java 33.33% 2 Missing ⚠️
...s/model/person/EmailContainsKeywordsPredicate.java 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...du/address/logic/commands/AbstractFindCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...eedu/address/logic/commands/FindByNameCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Person.java 97.14% <100.00%> (-0.08%) 19.00 <0.00> (ø)
...s/model/person/EmailContainsKeywordsPredicate.java 70.00% <0.00%> (+70.00%) 5.00 <0.00> (+5.00)
...edu/address/logic/commands/FindByEmailCommand.java 71.42% <71.42%> (ø) 3.00 <3.00> (?)
.../seedu/address/logic/parser/FindCommandParser.java 70.58% <33.33%> (-9.42%) 4.00 <0.00> (ø)

Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should enable us to find by email

@yooplo yooplo marked this pull request as ready for review October 10, 2024 07:40
@yooplo yooplo added the priority.High Must do label Oct 10, 2024
@yooplo yooplo added the type.Enhancement An enhancement to an existing story label Oct 10, 2024
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge sort

+ "Example:\n"
+ COMMAND_WORD + " " + FIND_NAME_COMMAND_WORD + " alice bob charlie\n"
+ COMMAND_WORD + " " + FIND_CONTACT_COMMAND_WORD + " [CONTACT NUMBER]\n"
+ COMMAND_WORD + " " + FIND_EMAIL_COMMAND_WORD + " [email protected]";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sufficient for a general instruction to guide the user

return false;
}
return super.predicate.equals(otherFindCommand.predicate);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps can keep in view to use this.getPredicate() instead of directly accessing the super.predicate field although it is allowed (or remove the getPredicate() entirely, undecided as of now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants