Implement duplicate email checking feature #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
CYX22222003
added
type.Enhancement
KrashKart
approved these changes
Oct 10, 2024
| @@ -33,7 +33,7 @@ public class UniquePersonList implements Iterable<Person> { | |||
| */ | |||
| public boolean contains(Person toCheck) { | |||
| requireNonNull(toCheck); | |||
| return internalList.stream().anyMatch(toCheck::isSamePerson); | |||
| return internalList.stream().anyMatch(toCheck::hasDuplicateInfo); | |||
There was a problem hiding this comment.
This should check if the list has any Person with the same email and name
| * This is to avoid adding duplicate contact in the contact list. | ||
| */ | ||
| public boolean hasDuplicateInfo(Person otherPerson) { | ||
| return this.isSamePerson(otherPerson) || this.hasSameEmail(otherPerson); |
There was a problem hiding this comment.
This checks for both the name and the email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45