Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code refactor #380

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Minor code refactor #380

merged 2 commits into from
Nov 11, 2024

Conversation

CYX22222003
Copy link

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...seedu/address/logic/commands/DeleteTagCommand.java 76.00% <ø> (ø) 9.00 <0.00> (ø)
...u/address/logic/parser/DeleteTagCommandParser.java 83.33% <ø> (ø) 2.00 <0.00> (ø)
...c/main/java/seedu/address/model/CampusConnect.java 88.23% <ø> (-0.45%) 20.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...va/seedu/address/model/VersionedCampusConnect.java 87.50% <ø> (ø) 8.00 <0.00> (ø)

chrisjohntan
chrisjohntan approved these changes Nov 11, 2024
View reviewed changes
Copy link

@chrisjohntan chrisjohntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@CYX22222003 CYX22222003 merged commit c9c9135 into AY2425S1-CS2103T-F14a-4:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjohntan chrisjohntan chrisjohntan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CYX22222003 @chrisjohntan