Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues raised in PE-D #359

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Fix issues raised in PE-D #359

merged 3 commits into from
Nov 10, 2024

Conversation

KrashKart
Copy link

@KrashKart KrashKart commented Nov 10, 2024 •
edited
Loading

@KrashKart KrashKart added the type.DocumentationBug UG / DG needs to be updated label Nov 10, 2024
@KrashKart KrashKart added this to the v1.6 milestone Nov 10, 2024
@KrashKart KrashKart self-assigned this Nov 10, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@KrashKart KrashKart marked this pull request as ready for review November 10, 2024 01:33
@chrisjohntan chrisjohntan mentioned this pull request Nov 10, 2024
Merged
chrisjohntan
chrisjohntan requested changes Nov 10, 2024
View reviewed changes
Copy link

@chrisjohntan chrisjohntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 78 in DG needs to be changed too for the UI link. See #360

@KrashKart KrashKart merged commit 242cb8b into AY2425S1-CS2103T-F14a-4:master Nov 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjohntan chrisjohntan chrisjohntan approved these changes

Assignees

@KrashKart KrashKart

Labels
type.DocumentationBug UG / DG needs to be updated
Projects
None yet
Milestone
v1.6
2 participants
@KrashKart @chrisjohntan