Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for manual testing for instruction testing #275

Merged

Conversation

CYX22222003
Copy link

No description provided.

@CYX22222003 CYX22222003 marked this pull request as ready for review November 7, 2024 15:35
KrashKart
KrashKart previously approved these changes Nov 7, 2024
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge

EDIT: INVALID

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
@KrashKart KrashKart dismissed their stale review November 7, 2024 16:23

Spotted potential mistake

KrashKart
KrashKart previously approved these changes Nov 7, 2024
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
@KrashKart KrashKart dismissed their stale review November 7, 2024 16:31

Error spotted, accidentally approved, sorry

Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the spam, I'm super tired

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@chrisjohntan chrisjohntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CYX22222003 CYX22222003 dismissed KrashKart’s stale review November 8, 2024 00:03

Concerns addressed

@CYX22222003 CYX22222003 merged commit 320961a into AY2425S1-CS2103T-F14a-4:master Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants