Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove traces of address book #260

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Remove traces of address book #260

merged 4 commits into from
Nov 7, 2024

Conversation

CYX22222003
Copy link

@CYX22222003 CYX22222003 commented Nov 7, 2024 •
edited by KrashKart
Loading

Some messages displayed still use "address book".

I have changed all of these to "campus connect".

We can correct our documentation at the last iteration.

Closes #259

CYX22222003
CYX22222003 commented Nov 7, 2024
View reviewed changes
src/main/java/seedu/address/logic/commands/AddCommand.java
*/
public class AddCommand extends Command {

public static final String COMMAND_WORD = "add";

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a person to the address book. "
public static final String MESSAGE_USAGE = COMMAND_WORD + ": Adds a person to the campus connect. "
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a feature change.

src/main/java/seedu/address/logic/commands/AddCommand.java
@@ -33,7 +33,7 @@ public class AddCommand extends Command {
+ PREFIX_TAG + "owesMoney";

public static final String MESSAGE_SUCCESS = "New person added: %1$s";
public static final String MESSAGE_DUPLICATE_PERSON = "This person already exists in the address book";
public static final String MESSAGE_DUPLICATE_PERSON = "This person already exists in the campus connect";
Copy link
Author

@CYX22222003 CYX22222003 Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@CYX22222003
Copy link
Author

./seedu/address/MainApp.java:71: * Returns a {@code ModelManager} with the data from {@code storage}'s address book and {@code userPrefs}.

./seedu/address/MainApp.java:72: * The data from the sample address book will be used instead if {@code storage}'s address book is not found,
./seedu/address/MainApp.java:73: * or an empty address book will be used instead if errors occur when reading {@code storage}'s address book.
./seedu/address/model/CampusConnect.java:103: * Returns true if a person with the same identity as {@code person} exists in the address book.
./seedu/address/model/CampusConnect.java:111: * Adds a person to the address book.
./seedu/address/model/CampusConnect.java:112: * The person must not already exist in the address book.
./seedu/address/model/Model.java:42: * Returns the user prefs' address book file path.
./seedu/address/model/Model.java:47: * Sets the user prefs' address book file path.
./seedu/address/model/Model.java:52: * Replaces address book data with the data in {@code campusConnect}.
./seedu/address/model/Model.java:65: * Returns true if a person with the same identity as {@code person} exists in the address book.
./seedu/address/model/Model.java:71: * The person must exist in the address book.
./seedu/address/model/Model.java:88: * {@code person} must not already exist in the address book.
./seedu/address/model/Model.java:99: * {@code target} must exist in the address book.
./seedu/address/model/Model.java:100: * The person identity of {@code editedPerson} must not be the same as another existing person in the address book.
./seedu/address/model/ModelManager.java:22: * Represents the in-memory model of the address book data.
./seedu/address/model/person/Name.java:7: * Represents a Person's name in the address book.
./seedu/address/model/person/Person.java:16: * Represents a Person in the address book.
./seedu/address/model/person/Phone.java:7: * Represents a Person's phone number in the address book.
./seedu/address/model/ReadOnlyCampusConnect.java:8: * Unmodifiable view of an address book
./seedu/address/model/tag/Tag.java:7: * Represents a Tag in the address book.
./seedu/address/storage/JsonSerializableCampusConnect.java:44: * Converts this address book into the model's {@code CampusConnect} object.

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
...ava/seedu/address/logic/commands/ClearCommand.java 55.55% <ø> (ø) 3.00 <0.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 97.26% <ø> (ø) 12.00 <0.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...c/main/java/seedu/address/model/CampusConnect.java 83.01% <ø> (ø) 19.00 <0.00> (ø)
...rc/main/java/seedu/address/model/person/Email.java 92.85% <ø> (ø) 6.00 <0.00> (ø)

CYX22222003
CYX22222003 commented Nov 7, 2024
View reviewed changes
src/main/java/seedu/address/logic/commands/EditCommand.java
@@ -47,7 +47,7 @@ public class EditCommand extends Command {

public static final String MESSAGE_EDIT_PERSON_SUCCESS = "Edited Person: %1$s";
public static final String MESSAGE_NOT_EDITED = "At least one field to edit must be provided.";
public static final String MESSAGE_DUPLICATE_PERSON = "This person already exists in the address book.";
public static final String MESSAGE_DUPLICATE_PERSON = "This person already exists in the campus connect.";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

src/main/java/seedu/address/logic/commands/ExitCommand.java
@@ -9,7 +9,7 @@ public class ExitCommand extends Command {

public static final String COMMAND_WORD = "exit";

public static final String MESSAGE_EXIT_ACKNOWLEDGEMENT = "Exiting Address Book as requested ...";
public static final String MESSAGE_EXIT_ACKNOWLEDGEMENT = "Exiting Campus Connect as requested ...";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

KrashKart
KrashKart approved these changes Nov 7, 2024
View reviewed changes
Copy link

@KrashKart KrashKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Perhaps can change to CampusConnect in the future to sound more professional but this will do for today

@CYX22222003 CYX22222003 merged commit 255fab1 into AY2425S1-CS2103T-F14a-4:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrashKart KrashKart KrashKart approved these changes

@chrisjohntan chrisjohntan Awaiting requested review from chrisjohntan

@yooplo yooplo Awaiting requested review from yooplo

@blackpanther9229 blackpanther9229 Awaiting requested review from blackpanther9229

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traces of address book
2 participants
@CYX22222003 @KrashKart