Fix cattag duplicate tag within command #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Comment on lines
+84
to
+95
| **[Add](#adding-a-person-add)** | `add n/NAME p/PHONE_NUMBER e/EMAIL [t/TAG]…` <br> e.g., `add n/James Ho p/91231234 e/[email protected] t/friend t/classmate` | ||
| **[Clear](#clearing-all-entries--clear)** | `clear` | ||
| **[Delete](#deleting-a-person--delete)** | `delete INDEX`<br> e.g., `delete 3` | ||
| **[Edit](#editing-a-person--edit)** | `edit INDEX [n/NAME] [p/PHONE_NUMBER] [e/EMAIL] [t/TAG]…`<br> e.g.,`edit 2 n/James Lee e/[email protected]` | ||
| **[Find by contact information](#locating-persons-by-contact-information-find)** | `find PREFIX/KEYWORD [PREFIX/MORE_KEYWORDS]…`<br> e.g., `find n/James t/floorball` | ||
| **[Delete tag](#deleting-a-persons-tag--deltag)** | `deltag INDEX t/KEYWORD` <br> e.g. `deltag 1 t/friend` | ||
| **[Add tag](#adds-tags-to-a-specific-person--addtag)** | `addtag INDEX t/KEYWORD [t/MORE_TAGS]…` <br> e.g. `addtag 1 t/friend t/classmate` | ||
| **[Categorize tag](#categorizing-a-tag--cattag)** | `cattag t/TAG [t/MORE_TAGS…] CATEGORY` <br> e.g. `cattag t/floorball t/mahjong activity` | ||
| **[Undo action](#undo-a-command--undo)** | `undo` | ||
| **[Redo action](#redo-a-command-redo)** | `redo` | ||
| **[List](#listing-all-persons--list)** | `list` | ||
| **[Help](#viewing-help--help)** | `help` |
Comment on lines
+245
to
+247
| * `cattag t/CS2100 acads` categorizes the tag `CS2100` under `Academics` and display colour of the tag`CS2100` becomes `Gold`. | ||
| * `cattag t/floorball t/mahjong activity` categorizes both tags `floorball` and `mahjong` under `Activities` with colour `Blue`. | ||
| * Newly created tags (by [`add`](#adding-a-person-add) or [`addtag`](#adds-tags-to-a-specific-person--addtag)) will have category `General` and colour `Grey` by default. |
CYX22222003
approved these changes
Nov 7, 2024
| @@ -66,7 +68,7 @@ private boolean isDuplicateCategory(TagCategory cat) { | |||
| return updatedCategory.equals(cat); | |||
| } | |||
|
|
|||
| private String formatTags(List<Tag> tags) { | |||
There was a problem hiding this comment.
the use of set will solve duplicate tag expectedly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should:
cattag t/tag1 t/tag1 catAas a valid command, and settag1tocatAsuccessfully (if all other conditions are satisfied). Fixes Cattag bug when calling the same tag multiples time in one command #254