Cattag displaying bug #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we cattag 2 tags, it reponses "Category of tag [[tag1], [tag2]] ..." Instead, we just want "Category of tag [tag1], [tag2]..."
blackpanther9229
added
priority.Medium
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
The displaying error is fixed by #249, so all I do is add details to the UG |
yooplo
requested changes
Nov 7, 2024
| @@ -21,7 +21,7 @@ public class CategorizeTagCommand extends Command { | |||
|
|
|||
| public static final String MESSAGE_USAGE = COMMAND_WORD | |||
| + ": Categorizes a tag. Changes all occurrences of the specified tag to the desired category.\n" | |||
| + "Parameters: " + PREFIX_TAG + "TAG (existing tag label) CATEGORY\n" | |||
| + "Parameters: " + PREFIX_TAG + "TAG (at least one existing tag label) CATEGORY\n" | |||
There was a problem hiding this comment.
I think this would imply “t/tag1 tag2 tag3…” when in reality the correct format is “t/tag1 t/tag2 ….”
There was a problem hiding this comment.
I think this would imply “t/tag1 tag2 tag3…” when in reality the correct format is “t/tag1 t/tag2 ….”
That make sense
| * `cattag t/floorball t/mahjong activity` categorizes both tags `floorball` and `mahjong` under `Activities` | ||
| * `cattag t/CS2100 acads` categorizes the tag `CS2100` under `Academics` and color of `t/CS2100` become `Gold`. | ||
| * `cattag t/floorball t/mahjong activity` categorizes both tags `floorball` and `mahjong` under `Activities` with color `Blue`. | ||
| * Not-yet categorized tags have color `Grey` by default. |
blackpanther9229
merged commit 0fd80f7
into
AY2425S1-CS2103T-F14a-4:master
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.