Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zheng Jie's AboutUs details #17

Merged

Conversation

KrashKart
Copy link

Fixes #15

@KrashKart KrashKart added type.Chore Something that needs to be done, but not a story, bug, or an epic. priority.Medium Nice to have labels Oct 3, 2024
@KrashKart KrashKart added this to the v1.1 milestone Oct 3, 2024
@KrashKart KrashKart self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@KrashKart KrashKart removed their assignment Oct 3, 2024
@KrashKart KrashKart marked this pull request as draft October 3, 2024 06:46
@KrashKart KrashKart marked this pull request as ready for review October 3, 2024 06:49
@KrashKart KrashKart marked this pull request as draft October 3, 2024 07:00
This is to prevent merge conflicts.
@KrashKart KrashKart marked this pull request as ready for review October 3, 2024 07:03
docs/AboutUs.md Show resolved Hide resolved
Copy link

@yooplo yooplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems good!
valid picture, valid github, and nice portfolio


[[github](http://github.com/johndoe)] [[portfolio](team/johndoe.md)]
[[github](https://github.com/KrashKart)] [[portfolio](team/krashkart.md)]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice profile


<img src="images/johndoe.png" width="200px">
<img src="images/krashkart.png" width="200px">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice picture

@yooplo yooplo merged commit cad4afe into AY2425S1-CS2103T-F14a-4:master Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Chore Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Zheng Jie's AboutUs details
2 participants