Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zheng Jie's photo #14

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add Zheng Jie's photo #14

merged 1 commit into from
Oct 3, 2024

Conversation

KrashKart
Copy link

Fixes #13

@KrashKart KrashKart added this to the v1.1 milestone Oct 2, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

yooplo
yooplo approved these changes Oct 3, 2024
View reviewed changes
Copy link

@yooplo yooplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!
The file is in the right location, file name is as expected, the PR is sent from your fork, uses a separate branch: branch-Add_photo, and your commit message complies with the Git Conventions.

@KrashKart KrashKart merged commit 30f4d89 into AY2425S1-CS2103T-F14a-4:master Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yooplo yooplo yooplo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Add Zheng Jie's photo
2 participants
@KrashKart @yooplo