Add a configurable number of TCP streams #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use yotta config to define the number of TCP PCBs to allocate
|
cc @bogdanm |
|
Fixes ARMmbed/sockets#34 |
| #define MEMP_NUM_TCP_PCB 4 | ||
| #endif |
There was a problem hiding this comment.
The only thing I might change here is to add a #warning on the default case (4 streams) rather than defining it silently. But that's not mandatory, so +1.
|
@bogdanm I don't think that adding a warning here is necessarily a good idea. I do think, however, that this behaviour should be documented. |
bremoran
added a commit
that referenced
this pull request
Nov 2, 2015
Add a configurable number of TCP streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use yotta config to define the number of TCP PCBs to allocate