Improve coding style #106
Merged
Improve coding style #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegecko
requested changes
Jan 6, 2024
|
Thank you for your fast review! There are indeed some changes in usb.ts that tend to be confusing, that are basically changes to adapt the new version, so for now I'll remove them. Then, according to your guidance, I have put some code -related modifications to the patch 2. |
Thanks, can you pout it in a separate PR, so this PR is only code style changes? |
Sure, I will push them later. Now this PR only has coding style commit. |
thegecko
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for your excellent work. I really like dapjs, but it looks like it hasn't been updated for a while, and now there are some dependencies that haven't been updated for a long time, and some dependencies that have been deprecated.
I'm currently trying to update the dependencies to the latest, but I'm not sure if this repo still accepting contributions from the community, so let's start with the coding style :D