Кошелев (3) #4
Open
Кошелев (3) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AREXP
reviewed
Jul 14, 2021
tmdb.py
Outdated
|
|
||
| def get_movie_actors(movie_id): | ||
| if movie_id <= 0: | ||
| raise InvalidParameterError |
There was a problem hiding this comment.
Это правильнее задать валидатором в argparse. Функция не должна заботиться о том, что в скрипт передали некорректное значение.
К тому же, на такие значения API выдаст вполне конкретный ответ – 404, его и нужно показать пользователю
tmdb.py
Outdated
| top_movies += get_popular_movies(page) | ||
|
|
||
| result = [] | ||
| for index, movie in enumerate(top_movies[:number]): |
There was a problem hiding this comment.
У enumerate есть аргумент для старта, можно воспользоваться им, избавишься от одной из переменных
|
Внес правки и закоммитил |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Рефакторинг в соответствии с замечаниями