Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for 3.4 #20

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Update docs for 3.4 #20

merged 3 commits into from
Dec 6, 2022

Conversation

nickw1
Copy link
Collaborator

@nickw1 nickw1 commented Dec 4, 2022

Have significantly updated the docs for location-based so that they are current as at AR.js 3.4, see issue #19.

Also included are revised tutorials for location-based AR.js, both A-Frame and three.js.

@kalwalt @nicolocarpignoli could one of you review the changes, and then if acceptable I will merge. Thanks.

@kalwalt
Copy link
Member

kalwalt commented Dec 4, 2022

I will review this when i have a bit of time, thank you for the PR!

@nicolocarpignoli
Copy link
Member

wow this is great @nickw1 ! It is all good to me!

Also, another thing: are there some of my Medium article about location based that are probably outdated/not working anymore? I will edit them in case.

@nicolocarpignoli nicolocarpignoli self-requested a review December 5, 2022 07:37
@nickw1
Copy link
Collaborator Author

nickw1 commented Dec 5, 2022

@nicolocarpignoli thanks!

With your tutorial, I think it's just the AR.js location that needs to be updated, isn't this referring to an old version?

https://raw.githack.com/jeromeetienne/AR.js/master/aframe/build/aframe-ar.min.js

Then I think it will all work fine, so would be great if you could update it! Thanks.

@nickw1 nickw1 merged commit 3a8f965 into master Dec 6, 2022
@kalwalt
Copy link
Member

kalwalt commented Dec 6, 2022

Great @nickw1 , hadn't the time to look at the full changes but definetely it's a super description! Thank you again for this. 🙂

@nickw1
Copy link
Collaborator Author

nickw1 commented Dec 6, 2022

@kalwalt no worries - @nicolocarpignoli approved so I merged, hope that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants