Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update give_feedback.html #1483

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

KrishPatel1205
Copy link
Contributor

Related Issue:

Fixes issue: #1482

Description:

Things fixed:

  • Name field validation
  • Email field validation
  • Feedback field validation
  • Removing extra whitespace / trimming of the above mentioned field inputs

Screenshots / Video:

Before:

Screen.Recording.2024-10-27.at.6.33.57.PM.mov

After:

Screen.Recording.2024-10-27.at.6.32.42.PM.mov

Pull Request Checklist

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 1:13pm

@KrishPatel1205
Copy link
Contributor Author

@ANSHIKA-26 Check this out and it would be great if you could assign it level 2, Thank you!

@ANSHIKA-26 ANSHIKA-26 merged commit bdaca0c into ANSHIKA-26:main Oct 27, 2024
5 of 6 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1483 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants