Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflict of issue#1259 #1474

Closed
wants to merge 1 commit into from

Conversation

rahulbamnuya
Copy link

@rahulbamnuya rahulbamnuya commented Oct 27, 2024

Pull Request Checklis

Fixes: #1259
Issue: #1259
issue:#1259

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 9:02am

@rahulbamnuya rahulbamnuya changed the title update footer section issue #1259 Resolve conflict of issue#1259 Oct 27, 2024
@ANSHIKA-26
Copy link
Owner

@rahulbamnuya ticking all the boxes of PR checklist doesnt mean that you have followed it , this is not good , kindly follow each and every point of the checklist , show before and after screenshots , i have gone through your code changes in index.html file , you have done no significant changes at all , all you have done is remove/ add some blank lines / do some formatting , i dont understand what your code is fixing , kindly show and make a new PR with the proper format , this is unacceptable

@ANSHIKA-26 ANSHIKA-26 closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve colours combination and improve overlapping of text in footer section
2 participants