Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated overlapping of login and signup popup forms #1451

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Updated overlapping of login and signup popup forms #1451

merged 1 commit into from
Oct 27, 2024

Conversation

ygowthamr
Copy link
Contributor

@ygowthamr ygowthamr commented Oct 26, 2024 •
edited
Loading

Pull Request Description

Fix #1467

  • Issue: Fixes a bug where closing the signup popup displays the previously opened login popup.
  • Changes Made: Updated logic to ensure only one popup is displayed at a time.
  • Improvements: Enhanced event handling to close the current popup before opening a new one.
  • Testing: Verified that the functionality works correctly for both login and signup popups.
  • Review: Please check the changes for any further improvements.

@ANSHIKA-26
Pls review the code and assign me, Also give me labels like level2,gssoc-extd,hacktoberfest-accepted.

@vercel Vercel
Copy link

vercel bot commented Oct 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 3:03pm

@ygowthamr ygowthamr changed the title Updated overlapping of login and signup form Updated overlapping of login and signup popup forms Oct 26, 2024
@ANSHIKA-26
Copy link
Owner

issue number ?

@ygowthamr
Copy link
Contributor Author

@ANSHIKA-26
This does not have issue no i have directly kept PR request

@ygowthamr
Copy link
Contributor Author

ygowthamr commented Oct 27, 2024 •
edited
Loading

@ANSHIKA-26
Now added issue number pls assign me the issue, review this pr and merge it

@ygowthamr
Copy link
Contributor Author

@ANSHIKA-26
Pls merge this pr also

@ANSHIKA-26 ANSHIKA-26 merged commit 11c93a7 into ANSHIKA-26:main Oct 27, 2024
5 of 6 checks passed
@github-actions GitHub Actions
Copy link

🎉🎉 Thank you for your contribution! Your PR #1451 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gssoc-ext hacktoberfest-accepted level 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Bug ] : Updated overlapping of login and signup popup forms
2 participants
@ygowthamr @ANSHIKA-26