Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prev and next buttons in carousels in home page and catrgories page #1399

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

swathivemula7
Copy link
Contributor

@swathivemula7 swathivemula7 commented Oct 25, 2024

Pull Request Checklist

Closes #1289

I have mentioned only categories page carousel in the issue...but I also found that home page has a similar carousel...So I have added previous and next button in both the carousels...

Note: I was not able to the previous and next buttons perfectly in carousel page at the beginning since the slider animation was working with css keyframes...So I implemented the same functionality using javascript and added the buttons successfully..

Output video:
https://github.com/user-attachments/assets/789e939c-b55c-48af-8b76-ad8d733467d1

@ANSHIKA-26 Kindly review the PR at the earliest

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 10:54am

@hiteashgupta1 hiteashgupta1 merged commit 605c308 into ANSHIKA-26:main Oct 25, 2024
5 of 6 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1399 has been merged! 🎉🎉

@swathivemula7
Copy link
Contributor Author

swathivemula7 commented Oct 25, 2024

Hey @hiteashgupta1 , it took quite a time and effort to identify and redesign the slider functionality to javascript, removing keyframes and adding navigation buttons at two carousels. .Could you please consider upgrading the level to level2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding previous and next buttons to carausel in categories page
2 participants