Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed text box issue ! #1043 #1141

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

Subhajit-2023-44
Copy link
Contributor

@Subhajit-2023-44 Subhajit-2023-44 commented Oct 18, 2024

Hello PR,
Fixes #1043
Issue fixed(for both dark & light mode) & I also customize it by adding background color and shadow for both dark and light mode like other text boxes -

Before -

Screenshot 2024-10-18 134343
Screenshot 2024-10-18 134356

After -

Screenshot 2024-10-18 134122
Screenshot 2024-10-18 134138

Pull Request Checklist

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for aquamarine-duckanoo-d86f1a ready!

Name Link
🔨 Latest commit 0f578f1
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-duckanoo-d86f1a/deploys/67121a939aff1000082ee67b
😎 Deploy Preview https://deploy-preview-1141--aquamarine-duckanoo-d86f1a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Subhajit-2023-44
Copy link
Contributor Author

Subhajit-2023-44 commented Oct 18, 2024

@hiteashgupta1 merge and kindly upgrade the level 1 to 2, because I fixed main text issue & I also customize it by adding background color and shadow for both dark and light mode like other text boxes

@hiteashgupta1 hiteashgupta1 merged commit 6827dfa into ANSHIKA-26:main Oct 18, 2024
7 of 8 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1141 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve text box issue
2 participants