Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️FIX : Join the conversation - Name field validation #1127

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

akash70629
Copy link
Contributor

Description

Updates the "Name" field in the Join the conversation section to only accept alphabetical letters (a-z, A-Z), preventing invalid or spam submissions.

Fixes: #1125

Changes:

  • Added input validation to the "Name" field.

Type of PR

  • Bug fix

Screenshots

Before-
image

After -
image

Pull Request Checklist

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for aquamarine-duckanoo-d86f1a ready!

Name Link
🔨 Latest commit e54b033
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-duckanoo-d86f1a/deploys/671153235144120008e481da
😎 Deploy Preview https://deploy-preview-1127--aquamarine-duckanoo-d86f1a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ANSHIKA-26
Copy link
Owner

the after isnt really perfect , make the "name" tag go a little more above please

@akash70629
Copy link
Contributor Author

the after isnt really perfect , make the "name" tag go a little more above please

@ANSHIKA-26 , Although that is another issue, don't worry I'm gonna fix that ASAP.

@ANSHIKA-26
Copy link
Owner

thanks !

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 1:37pm

@akash70629
Copy link
Contributor Author

thanks !

Fixed ! Please merge it . @ANSHIKA-26

Final result -
image

@hiteashgupta1 hiteashgupta1 merged commit 9d92da8 into ANSHIKA-26:main Oct 18, 2024
4 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1127 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛BUG : Join the conversation - Name field validation
3 participants