Skip to content

Commit

Permalink
Merge pull request #949 from ICB-DCM/release_0.10.18
Browse files Browse the repository at this point in the history
Release 0.10.18

General:
* AMICI now comes with a logo
* implement getName function for models
* Updated documentation / examples

Python:
* Enable MSVC compilation of Python extensions (#847)
* Always recompile clibs and extensions (Closes #700)
* Extended PEtab support (Running
* enable multithreading in swig (#938)
* Fixes pysb (#902) (#907)

C++
* Build optimized AMICI and sundials by default (Closes #934)

Matlab:
* Fix(matlab) Compile CalcMD5 on demand (Fixes #914)
* Don't pass empty include strings to mex
* Fix Matlab compilation error if AMICI or model path contains blanks

CI:
* Running additional test models

... and various minor fixes/updates
  • Loading branch information
dweindl authored Feb 11, 2020
2 parents a040767 + 1fa9433 commit fcd0a4d
Show file tree
Hide file tree
Showing 53 changed files with 2,911 additions and 1,028 deletions.
31 changes: 31 additions & 0 deletions .github/workflows/deploy_sdist.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Deploy Python source distribution
on: push

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
with:
fetch-depth: 20

- name: apt
run: |
sudo apt-get install -y swig3.0 \
&& sudo ln -s /usr/bin/swig3.0 /usr/bin/swig
- name: pip
run: |
pip3 install --upgrade --user wheel \
&& pip3 install --upgrade --user setuptools
- name: Create AMICI sdist
run: |
cd python/sdist && /usr/bin/python3 setup.py sdist
- name: Archive sdist
uses: actions/upload-artifact@v1
with:
name: sdist
path: python/sdist/dist
53 changes: 53 additions & 0 deletions .github/workflows/test-benchmark-collection-models.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: Benchmark collection
on:
push:
branches:
- develop
- master

pull_request:
branches:
- master

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
with:
fetch-depth: 20

# install dependencies
- name: apt
run: |
sudo apt-get install -y swig3.0 libatlas-base-dev \
&& sudo ln -s /usr/bin/swig3.0 /usr/bin/swig
- name: pip
run: |
pip3 install --upgrade --user wheel \
&& pip3 install --upgrade --user setuptools
- run: pip3 install shyaml petab>=0.1.1
- run: |
echo ::add-path::${HOME}/.local/bin/
echo ::add-path::${GITHUB_WORKSPACE}/tests/performance/
# install AMICI
- name: Create AMICI sdist
run: |
cd python/sdist \
&& check_time.sh create_sdist /usr/bin/python3 setup.py sdist
- name: Install AMICI sdist
run: |
AMICI_PARALLEL_COMPILE=2 check_time.sh \
install_sdist pip3 install -v --user \
$(ls -t python/sdist/dist/amici-*.tar.gz | head -1)
# retrieve test models
- name: Download and test benchmark collection
# TODO do something more efficient than cloning this big repo
run: |
git clone --depth 1 https://github.com/LeonardSchmiester/Benchmark-Models.git \
&& cd Benchmark-Models && git checkout hackathon && cd .. \
&& export BENCHMARK_COLLECTION="$(pwd)/Benchmark-Models/hackathon_contributions_new_data_format/" \
&& tests/benchmark-models/test_benchmark_collection.sh
10 changes: 4 additions & 6 deletions .github/workflows/test-large-model.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- develop
- master
- fix_896_perftestfiles
- fix_945

pull_request:
branches:
Expand Down Expand Up @@ -52,12 +52,10 @@ jobs:
run: |
cd CS_Signalling_ERBB_RAS_AKT \
&& check_time.sh \
petab_import amici_import_petab.py -v \
petab_import amici_import_petab -v \
-n 'CS_Signalling_ERBB_RAS_AKT_petab' \
-s 'FroehlichKes2018/PEtab/CS_Signalling_ERBB_RAS_AKT_petab.xml' \
-c 'FroehlichKes2018/PEtab/conditions_petab.tsv' \
-m 'FroehlichKes2018/PEtab/measurements_petab.tsv' \
-p 'FroehlichKes2018/PEtab/parameters_petab.tsv' --no-compile
-y 'FroehlichKes2018/PEtab/FroehlichKes2018.yaml' \
--no-compile
# install model package
- name: Install test model
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ tests/sbml-test-suite/
tests/sedml-test-suite/
*/sbml-semantic-test-cases/*
tests/SBMLTestModels/
tests/benchmark-models/test_bmc
/python/test/amici-SBMLTest*/

python/examples/example_steadystate/model_steadystate_scaled/*
Expand All @@ -154,10 +155,13 @@ AMICI_guide.pdf
ThirdParty/bionetgen.tar.gz
ThirdParty/BioNetGen-*
ThirdParty/cpputest-master*
ThirdParty/doxygen/*
ThirdParty/mtocpp-master*
ThirdParty/sundials/build/*
ThirdParty/SuiteSparse/lib/*
ThirdParty/SuiteSparse/share/*
ThirdParty/SuperLU_MT_3.1/
ThirdParty/superlu_mt_3.1.tar.gz
ThirdParty/swig-*

_untracked/
29 changes: 29 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,33 @@ matrix:
on:
branch: master

- os: windows
# language python currently not supported on Windows
language: cpp
compiler: msvc
git:
# clone after enabled symlinks below
clone: false
env: PATH=/c/Python37:/c/Python37/Scripts:$PATH
before_install:
- export -f travis_fold travis_nanoseconds travis_time_start travis_time_finish
# allow PowerShell to run scripts
- powershell -Command Set-ExecutionPolicy Unrestricted -Force
# Enable Windows developer mode to support symlinks
- powershell -Command New-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock" -Name AllowDevelopmentWithoutDevLicense -Value 1 -PropertyType DWord
# stick to python 3.7 until there is a 3.8 wheel for windows
# as installation from sdist fails because of reasons...
- choco install python --version 3.7.5
- choco install swig
- python -m pip install --upgrade pip
- pip install --user -U numpy
- git clone -c core.symlinks=true https://github.com/ICB-DCM/AMICI.git && cd AMICI
- if [[ "$TRAVIS_PULL_REQUEST" == "false" ]]; then git checkout -qf $TRAVIS_COMMIT; elif [[ "$TRAVIS_PULL_REQUEST" != "false" ]]; then git fetch --update-head-ok origin pull/$TRAVIS_PULL_REQUEST/head:$TRAVIS_BRANCH && git checkout $TRAVIS_BRANCH; fi
# run BLAS installation script
- if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then powershell -File 'C:\Users\travis\build\AMICI\scripts\installOpenBLAS.ps1';export BLAS_LIBS BLAS_CFLAGS; fi
# define Windows environment variables in BLAS because PowerShell definition didn't do the trick
- if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then export BLAS_LIBS='/LIBPATH:C:\\BLAS\\OpenBLAS-0.3.6-x64\\lib libopenblas.lib' BLAS_CFLAGS='/IC:\\BLAS\\OpenBLAS-0.3.6-x64\\include'; fi

install:
- export BASE_DIR=`pwd`
# Build swig4.0 (not yet available with apt) to include pydoc in source distribution for pypi
Expand All @@ -146,6 +173,8 @@ install:
- if [[ "$CI_BUILD" == "TRUE" ]]; then ./scripts/buildAmici.sh; fi
- if [[ "$CI_ARCHIVE" == "TRUE" ]]; then ./scripts/installAmiciArchive.sh; fi
- if [[ "$CI_PYTHON" == "TRUE" ]]; then ./scripts/installAmiciSource.sh; fi
- if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then cd python/sdist && python setup.py sdist; fi
- if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then pip install $(ls -t dist/amici-*.tar.gz | head -1); fi

script:
- export -f travis_fold travis_nanoseconds travis_time_start travis_time_finish
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ project(amici)

set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD 14)
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
# require at least gcc 4.9, otherwise regex wont work properly
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9)
Expand Down
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# About AMICI
<img src="./documentation/gfx/banner.png" height="60" align="left">

## Advanced Multilanguage Interface for CVODES and IDAS

## About

AMICI provides a multi-language (Python, C++, Matlab) interface for the
[SUNDIALS](https://computing.llnl.gov/projects/sundials/) solvers
Expand Down Expand Up @@ -99,7 +103,13 @@ and/or
Parameter estimation for dynamical systems with discrete events and logical
operations. Bioinformatics, 33(7), 1049-1056.
doi:[10.1093/bioinformatics/btw764](https://doi.org/10.1093/bioinformatics/btw764)

When presenting work that employs AMICI, feel free to use one of the icons in
[documentation/gfx/](https://github.com/ICB-DCM/AMICI/tree/master/documentation/gfx), which are available under a [CC0](documentation/gfx/LICENSE.md) license:

<p align="center">
<img src="./documentation/gfx/logo_text.png" height="75">
</p>

## Status of SBML support in Python-AMICI

Expand Down
121 changes: 121 additions & 0 deletions documentation/gfx/LICENSE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
Creative Commons Legal Code

CC0 1.0 Universal

CREATIVE COMMONS CORPORATION IS NOT A LAW FIRM AND DOES NOT PROVIDE
LEGAL SERVICES. DISTRIBUTION OF THIS DOCUMENT DOES NOT CREATE AN
ATTORNEY-CLIENT RELATIONSHIP. CREATIVE COMMONS PROVIDES THIS
INFORMATION ON AN "AS-IS" BASIS. CREATIVE COMMONS MAKES NO WARRANTIES
REGARDING THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS
PROVIDED HEREUNDER, AND DISCLAIMS LIABILITY FOR DAMAGES RESULTING FROM
THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS PROVIDED
HEREUNDER.

Statement of Purpose

The laws of most jurisdictions throughout the world automatically confer
exclusive Copyright and Related Rights (defined below) upon the creator
and subsequent owner(s) (each and all, an "owner") of an original work of
authorship and/or a database (each, a "Work").

Certain owners wish to permanently relinquish those rights to a Work for
the purpose of contributing to a commons of creative, cultural and
scientific works ("Commons") that the public can reliably and without fear
of later claims of infringement build upon, modify, incorporate in other
works, reuse and redistribute as freely as possible in any form whatsoever
and for any purposes, including without limitation commercial purposes.
These owners may contribute to the Commons to promote the ideal of a free
culture and the further production of creative, cultural and scientific
works, or to gain reputation or greater distribution for their Work in
part through the use and efforts of others.

For these and/or other purposes and motivations, and without any
expectation of additional consideration or compensation, the person
associating CC0 with a Work (the "Affirmer"), to the extent that he or she
is an owner of Copyright and Related Rights in the Work, voluntarily
elects to apply CC0 to the Work and publicly distribute the Work under its
terms, with knowledge of his or her Copyright and Related Rights in the
Work and the meaning and intended legal effect of CC0 on those rights.

1. Copyright and Related Rights. A Work made available under CC0 may be
protected by copyright and related or neighboring rights ("Copyright and
Related Rights"). Copyright and Related Rights include, but are not
limited to, the following:

i. the right to reproduce, adapt, distribute, perform, display,
communicate, and translate a Work;
ii. moral rights retained by the original author(s) and/or performer(s);
iii. publicity and privacy rights pertaining to a person's image or
likeness depicted in a Work;
iv. rights protecting against unfair competition in regards to a Work,
subject to the limitations in paragraph 4(a), below;
v. rights protecting the extraction, dissemination, use and reuse of data
in a Work;
vi. database rights (such as those arising under Directive 96/9/EC of the
European Parliament and of the Council of 11 March 1996 on the legal
protection of databases, and under any national implementation
thereof, including any amended or successor version of such
directive); and
vii. other similar, equivalent or corresponding rights throughout the
world based on applicable law or treaty, and any national
implementations thereof.

2. Waiver. To the greatest extent permitted by, but not in contravention
of, applicable law, Affirmer hereby overtly, fully, permanently,
irrevocably and unconditionally waives, abandons, and surrenders all of
Affirmer's Copyright and Related Rights and associated claims and causes
of action, whether now known or unknown (including existing as well as
future claims and causes of action), in the Work (i) in all territories
worldwide, (ii) for the maximum duration provided by applicable law or
treaty (including future time extensions), (iii) in any current or future
medium and for any number of copies, and (iv) for any purpose whatsoever,
including without limitation commercial, advertising or promotional
purposes (the "Waiver"). Affirmer makes the Waiver for the benefit of each
member of the public at large and to the detriment of Affirmer's heirs and
successors, fully intending that such Waiver shall not be subject to
revocation, rescission, cancellation, termination, or any other legal or
equitable action to disrupt the quiet enjoyment of the Work by the public
as contemplated by Affirmer's express Statement of Purpose.

3. Public License Fallback. Should any part of the Waiver for any reason
be judged legally invalid or ineffective under applicable law, then the
Waiver shall be preserved to the maximum extent permitted taking into
account Affirmer's express Statement of Purpose. In addition, to the
extent the Waiver is so judged Affirmer hereby grants to each affected
person a royalty-free, non transferable, non sublicensable, non exclusive,
irrevocable and unconditional license to exercise Affirmer's Copyright and
Related Rights in the Work (i) in all territories worldwide, (ii) for the
maximum duration provided by applicable law or treaty (including future
time extensions), (iii) in any current or future medium and for any number
of copies, and (iv) for any purpose whatsoever, including without
limitation commercial, advertising or promotional purposes (the
"License"). The License shall be deemed effective as of the date CC0 was
applied by Affirmer to the Work. Should any part of the License for any
reason be judged legally invalid or ineffective under applicable law, such
partial invalidity or ineffectiveness shall not invalidate the remainder
of the License, and in such case Affirmer hereby affirms that he or she
will not (i) exercise any of his or her remaining Copyright and Related
Rights in the Work or (ii) assert any associated claims and causes of
action with respect to the Work, in either case contrary to Affirmer's
express Statement of Purpose.

4. Limitations and Disclaimers.

a. No trademark or patent rights held by Affirmer are waived, abandoned,
surrendered, licensed or otherwise affected by this document.
b. Affirmer offers the Work as-is and makes no representations or
warranties of any kind concerning the Work, express, implied,
statutory or otherwise, including without limitation warranties of
title, merchantability, fitness for a particular purpose, non
infringement, or the absence of latent or other defects, accuracy, or
the present or absence of errors, whether or not discoverable, all to
the greatest extent permissible under applicable law.
c. Affirmer disclaims responsibility for clearing rights of other persons
that may apply to the Work or any use thereof, including without
limitation any person's Copyright and Related Rights in the Work.
Further, Affirmer disclaims responsibility for obtaining any necessary
consents, permissions or other rights required for any use of the
Work.
d. Affirmer understands and acknowledges that Creative Commons is not a
party to this document and has no duty or obligation with respect to
this CC0 or use of the Work.
1 change: 1 addition & 0 deletions documentation/gfx/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The graphics in this directory are under CC0 1.0 license. See LICENSE.md file.
Binary file added documentation/gfx/banner.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added documentation/gfx/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit fcd0a4d

Please sign in to comment.