-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi memtile buffer viz #73
Merged
mariodruiz
merged 42 commits into
AMDResearch:main
from
mariodruiz:multi-buff-visualisation
Oct 24, 2024
Merged
Fix multi memtile buffer viz #73
mariodruiz
merged 42 commits into
AMDResearch:main
from
mariodruiz:multi-buff-visualisation
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test to check for non anonymous kernels and MTSplit and MTConcat * Do not trace application again if args are the same * Fix call * Remove unused test * Add testcases with float numbers * Add memtile reduce test * Flake8 * Fix source name * Fix name * Fix behavior * Add more comprehensive tests * Flake8 * Increase tolerance * Set random seed * Raise error if datatype not supported for mt links * Remove trailing whitespace and some flake8
) * Update installation script * Install latest version of the driver and Riallto * Add intructions to run Riallto from other users * Set shell to bash * Specify docker owner via username * Fix args check * Add information about username ownership * Remove unneded as base * Remove all directories * Check if args are less or equal to 2 * Fix args check * Grammar
* Verify that kernel code is wrapped in extern C * Remove curly braces * Add breakline * Change raise type * Fix checks * Return RunTime error * Check construct * Use Syntax error * Change way we do pytest * Only check if extern C exists * Remove unused check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem solved by the commit
Fix viz for multiple
MTPassThrough
andMTSplit
How is the problem solved?
Adding more test to cover as much test cases and possible and fixing the logic
Are there any risks associated to the change?
No
Is there a documentation impact?
No
Checklist