Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi memtile buffer viz #73

Merged
merged 42 commits into from
Oct 24, 2024

Conversation

mariodruiz
Copy link
Collaborator

Describe the problem solved by the commit

Fix viz for multiple MTPassThrough and MTSplit

How is the problem solved?

Adding more test to cover as much test cases and possible and fixing the logic

Are there any risks associated to the change?

No

Is there a documentation impact?

No

Checklist

  • I added a test to cover my changes
  • Existing and new test pass
  • I read and I accept the CONTRIBUTING.md guidelines

mariodruiz and others added 30 commits September 14, 2024 18:14
* Add test to check for non anonymous kernels and MTSplit and MTConcat

* Do not trace application again if args are the same

* Fix call

* Remove unused test

* Add testcases with float numbers

* Add memtile reduce test

* Flake8

* Fix source name

* Fix name

* Fix behavior

* Add more comprehensive tests

* Flake8

* Increase tolerance

* Set random seed

* Raise error if datatype not supported for mt links

* Remove trailing whitespace and some flake8
)

* Update installation script

* Install latest version of the driver and Riallto

* Add intructions to run Riallto from other users

* Set shell to bash

* Specify docker owner via username

* Fix args check

* Add information about username ownership

* Remove unneded as base

* Remove all directories

* Check if args are less or equal to 2

* Fix args check

* Grammar
* Verify that kernel code is wrapped in extern C

* Remove curly braces

* Add breakline

* Change raise type

* Fix checks

* Return RunTime error

* Check construct

* Use Syntax error

* Change way we do pytest

* Only check if extern C exists

* Remove unused check
@mariodruiz mariodruiz merged commit cd371b7 into AMDResearch:main Oct 24, 2024
0 of 2 checks passed
@mariodruiz mariodruiz deleted the multi-buff-visualisation branch October 24, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant